Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ansible-lint logo to bracket-dot from codicons #2424

Merged
merged 1 commit into from Sep 15, 2022

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Sep 15, 2022

In order to make linter logo easier to recognize and also possible to display in vscode status-bar, we adopt the bracket-dot icon.

This should also sort the lack of favicon on multiple browsers by making use of the most compatible format for these (.ico).

@ssbarnea ssbarnea requested review from a team as code owners September 15, 2022 17:16
@github-actions github-actions bot added the bug label Sep 15, 2022
ssbarnea added a commit to ssbarnea/vscode-ansible that referenced this pull request Sep 15, 2022
Adopts the new ansible-lint icon for status-bar icon instead of the
previous pass-filled icon, which was already used by other extensions,
like Grammarly.

Related: ansible/ansible-lint#2424
@ssbarnea ssbarnea force-pushed the fix/logo branch 3 times, most recently from 3216837 to 94be1c6 Compare September 15, 2022 17:45
In order to make linter logo easier to recognize an dalso possible to
display in vscode status-bar, we adopt the bracket-dot icon.
@cidrblock
Copy link
Contributor

+1

ssbarnea added a commit to ansible/vscode-ansible that referenced this pull request Sep 15, 2022
Adopts the new ansible-lint icon for status-bar icon instead of the
previous pass-filled icon, which was already used by other extensions,
like Grammarly.

Related: ansible/ansible-lint#2424
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants