Replace no-jinja-nesting with jinja[invalid] #2436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
force-pushed
the
fix/broken-jinja
branch
from
e205c4e
to
e945d86
Compare
- Modifies jinja rule to also perform the validity testing that was previously part of no-jinja-nesting rule - Remove no-jinja-nesting - New implementation is far better as it relies on Ansible own templating instead of the old regex approach, which was prone to false-positives.
ssbarnea
force-pushed
the
fix/broken-jinja
branch
from
e945d86
to
9884f83
Compare
ssbarnea
changed the title
davedittrich
pushed a commit
to davedittrich/ansible-lint
that referenced
this pull request
Sep 27, 2022
- Modifies jinja rule to also perform the validity testing that was previously part of no-jinja-nesting rule - Remove no-jinja-nesting - New implementation is far better as it relies on Ansible own templating instead of the old regex approach, which was prone to false-positives.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jinjarule to also perform the validity testing that was previously part of no-jinja-nesting ruleno-jinja-nestingrule