api: enable matchtask() to return list[MatchError] #2445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extends the API for matchtask() to allow implementations to also return list[MatchError), in addition to already supported results. This change extends the API but does not break existing users. In the future we might want to discourage/deprecate returning the other type of results (bool, str or MatchError). This change is needed in order to enable other rules to return multiple errors within a single task file, like enabling `name` rule to also report `name[templating]` errors.
cidrblock
approved these changes
Sep 19, 2022
davedittrich
pushed a commit
to davedittrich/ansible-lint
that referenced
this pull request
Sep 27, 2022
Extends the API for matchtask() to allow implementations to also return list[MatchError), in addition to already supported results. This change extends the API but does not break existing users. In the future we might want to discourage/deprecate returning the other type of results (bool, str or MatchError). This change is needed in order to enable other rules to return multiple errors within a single task file, like enabling `name` rule to also report `name[templating]` errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends the API for matchtask() to allow implementations to also return list[MatchError), in addition to already supported results.
This change extends the API but does not break existing users. In the future we might want to discourage/deprecate returning the other type of results (bool, str or MatchError).
This change is needed in order to enable other rules to return multiple errors within a single task file, like enabling
namerule to also reportname[templating]errors. See #2444