Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: yamllint rule #2450

Merged
merged 2 commits into from Sep 20, 2022
Merged

Docs: yamllint rule #2450

merged 2 commits into from Sep 20, 2022

Conversation

oraNod
Copy link
Collaborator

@oraNod oraNod commented Sep 19, 2022

This PR updates documentation for the yaml rule.

@oraNod oraNod requested review from a team as code owners September 19, 2022 19:30
@ssbarnea
Copy link
Member

You need to keep the yaml.md filename. We had to avoid using yaml.py on this rule, but the documentation must remain yaml.md. Is the only exception.

@oraNod
Copy link
Collaborator Author

oraNod commented Sep 20, 2022

You need to keep the yaml.md filename. We had to avoid using yaml.py on this rule, but the documentation must remain yaml.md. Is the only exception.

Thanks, Sorin. I wasn't sure about this one so took a punt and renamed the md file. I've changed it back.

@ssbarnea ssbarnea added the bug label Sep 20, 2022
@ssbarnea ssbarnea merged commit f19702d into ansible:main Sep 20, 2022
mnaser pushed a commit to mnaser/ansible-lint that referenced this pull request Sep 20, 2022
@oraNod @pre-commit-ci @mnaser
Docs: yamllint rule (ansible#2450)
e5463bb 
* docs for yamllint rule

* chore: auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
davedittrich pushed a commit to davedittrich/ansible-lint that referenced this pull request Sep 27, 2022
@oraNod @pre-commit-ci @davedittrich
Docs: yamllint rule (ansible#2450)
efefbea 
* docs for yamllint rule

* chore: auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@oraNod oraNod deleted the rule-docs-yaml branch October 6, 2022 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea approved these changes

@cidrblock cidrblock Awaiting requested review from cidrblock cidrblock is a code owner automatically assigned from ansible/devtools

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo priyamsahoo is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oraNod @ssbarnea