Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use site.getuserbase() to detect ansible executable #2477

Merged
merged 1 commit into from Sep 21, 2022
Merged

Use site.getuserbase() to detect ansible executable #2477

merged 1 commit into from Sep 21, 2022

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Sep 21, 2022 •
edited

As it is quite common for many users to miss adding python bin scripts folder to their PATH, even if pip does warn them about the issue, we now add it dynamically.

Fixes: #2357

@ssbarnea ssbarnea requested review from a team as code owners September 21, 2022 12:24
@github-actions github-actions bot added the bug label Sep 21, 2022
@ssbarnea
Use site.getuserbase() to detect ansible executable
e604881 
As it is quite common for many users to miss adding python bin scripts
folder to their PATH, even if pip does warn them about the issue, we
now add it dynamically.

Fixes: ansible#2357
This was referenced Sep 21, 2022
Closed
Closed
cidrblock
cidrblock approved these changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@cidrblock cidrblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installed on macOs 12.6 w/o venv, version reported 0.0.0

@ssbarnea ssbarnea merged commit 455a909 into ansible:main Sep 21, 2022
@ssbarnea ssbarnea deleted the fix/ansible-path branch September 21, 2022 15:28
@hardcore
Copy link

Installed on macOs 12.6 w/o venv, version reported 0.0.0

did you update ansible-lint with "brew install ansible-lint"?

@ssbarnea
Copy link
Member Author

@hardcore No. We are not updating brew recipes ourselves, mainly because brew requires manual intervention in order to make any new release. We release ansible-lint quite often, sometimes with even two releases in a single week. If you convince brew folks to automate their process, it would be cool. That is one one the reasons brew is not listed on our installation documentation. I love brew and use it a LOT, but not for python tools/packages, as it is always lagging.

I suspect that the brew version bad error is because they installed the package from a shallow clone. To get the proper version number, you need a full clone, or the python wheel (pip).

@hardcore
Copy link

Great! Thank you for the necessary info about brew and python things :-)

davedittrich pushed a commit to davedittrich/ansible-lint that referenced this pull request Sep 27, 2022
@ssbarnea @davedittrich
Use site.getuserbase() to detect ansible executable (ansible#2477)
6a8ffc6 
As it is quite common for many users to miss adding python bin scripts
folder to their PATH, even if pip does warn them about the issue, we
now add it dynamically.

Fixes: ansible#2357
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cidrblock cidrblock cidrblock approved these changes

@ganeshrn ganeshrn Awaiting requested review from ganeshrn ganeshrn is a code owner automatically assigned from ansible/devtools

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo priyamsahoo is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ansible-lint print WARNING (PATH altered to include)
3 participants
@ssbarnea @hardcore @cidrblock