Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure we do not return relative paths outside the project #2492

Merged
merged 1 commit into from Sep 23, 2022
Merged

Ensure we do not return relative paths outside the project #2492

merged 1 commit into from Sep 23, 2022

Conversation

ssbarnea
Copy link
Member

Makes normpath match normpath_path one and avoid returning relative
paths outside current working directory / project.

This should fix the WSL job, which was running the testing outside
user home directory, and that produced different file paths.

@ssbarnea
Ensure we do not return relative paths outside the project
552012c 
Makes normpath match normpath_path one and avoid returning relative
paths outside current working directory / project.

This should fix the WSL job, which was running the testing outside
user home directory, and that produced different file paths.
@ssbarnea ssbarnea requested review from a team as code owners September 23, 2022 18:53
@github-actions github-actions bot added the bug label Sep 23, 2022
@ssbarnea ssbarnea merged commit 31a1092 into ansible:main Sep 23, 2022
@ssbarnea ssbarnea deleted the fix/wsl branch September 23, 2022 19:13
davedittrich pushed a commit to davedittrich/ansible-lint that referenced this pull request Sep 27, 2022
@ssbarnea @davedittrich
Ensure we do not return relative paths outside the project (ansible#2492
88feef8 
)

Makes normpath match normpath_path one and avoid returning relative
paths outside current working directory / project.

This should fix the WSL job, which was running the testing outside
user home directory, and that produced different file paths.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cidrblock cidrblock Awaiting requested review from cidrblock cidrblock is a code owner automatically assigned from ansible/devtools

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo priyamsahoo is a code owner automatically assigned from ansible/devtools

@shatakshiiii shatakshiiii Awaiting requested review from shatakshiiii shatakshiiii is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ssbarnea