var-naming: also recognize vars with set_fact module #2496
Merged
+87
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
requested changes
Sep 26, 2022
There was a problem hiding this comment.
I am not sure if I fully understand the bug, but if that is fixing something that was not working correctly before, why I am not seeing any change being made to the tests? ... a change that would ensure
that we not see a regression in the future.
Look at the bottom of the file for few tests, you might be able to just
alter them to test the new outcome. I would be able to check manually
the tests without including you change and see that they fail with current implementation.
|
Got it. I will add tests. |
ssbarnea
approved these changes
Sep 27, 2022
Signed-off-by: nishipy <goodisonev4@gmail.com>
Signed-off-by: nishipy <goodisonev4@gmail.com>
ssbarnea
changed the title
ssbarnea
changed the title
ssbarnea
added a commit
to ssbarnea/ansible-lint
that referenced
this pull request
Oct 5, 2022
* Update var_naming for set_fact module Signed-off-by: nishipy <goodisonev4@gmail.com> * Add test for var_naming with pattern Signed-off-by: nishipy <goodisonev4@gmail.com> * More fixes Signed-off-by: nishipy <goodisonev4@gmail.com> Co-authored-by: Sorin Sbarnea <sorin.sbarnea@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2065