Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add no-shorthand rule as experimental #2527

Merged
merged 1 commit into from Oct 1, 2022
Merged

Add no-shorthand rule as experimental #2527

merged 1 commit into from Oct 1, 2022

Conversation

ssbarnea
Copy link
Member

Fixes: #2117

@ssbarnea ssbarnea requested review from a team as code owners September 30, 2022 19:01
@ssbarnea ssbarnea force-pushed the feat/no-shorthand branch 3 times, most recently from 4dd774a to 72a059a Compare October 1, 2022 09:01
@ssbarnea ssbarnea merged commit c62e9df into ansible:main Oct 1, 2022
@ssbarnea ssbarnea deleted the feat/no-shorthand branch October 1, 2022 09:34
hswong3i added a commit to alvistack/ansible-role-bleachbit that referenced this pull request Oct 2, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2527
92fe596
hswong3i added a commit to alvistack/ansible-role-bitbucket that referenced this pull request Oct 2, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2527
f097c43
hswong3i added a commit to alvistack/ansible-role-ansible that referenced this pull request Oct 2, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2527
2330074
hswong3i added a commit to alvistack/ansible-role-bamboo that referenced this pull request Oct 2, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2527
ba06635
hswong3i added a commit to alvistack/ansible-role-cilium that referenced this pull request Oct 2, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2527
b70b9c7
hswong3i added a commit to alvistack/ansible-role-audacity that referenced this pull request Oct 2, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2527
44032ae
hswong3i added a commit to alvistack/ansible-role-ceph_mgr that referenced this pull request Oct 2, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2527
586e6f9
hswong3i added a commit to alvistack/ansible-role-audacious that referenced this pull request Oct 2, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2527
b7bf90b
hswong3i added a commit to alvistack/ansible-role-buildah that referenced this pull request Oct 2, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2527
6a6791e
hswong3i added a commit to alvistack/ansible-role-ceph_common that referenced this pull request Oct 2, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2527
2391bba
hswong3i added a commit to alvistack/ansible-role-catatonit that referenced this pull request Oct 2, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2527
3601260
hswong3i added a commit to alvistack/ansible-role-ceph_mds that referenced this pull request Oct 2, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2527
5bb05ee
hswong3i added a commit to alvistack/ansible-role-bootstrap that referenced this pull request Oct 2, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2527
0451e9f
hswong3i added a commit to alvistack/ansible-role-ceph_mon that referenced this pull request Oct 2, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2527
0843251
hswong3i added a commit to alvistack/ansible-role-chrome that referenced this pull request Oct 2, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2527
df52bd0
hswong3i added a commit to alvistack/ansible-role-ceph_osd that referenced this pull request Oct 2, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2527
4cb5712
hswong3i added a commit to alvistack/docker-gitlab-ee that referenced this pull request Oct 2, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2527
abd0bf5
hswong3i added a commit to alvistack/docker-gitlab-ce that referenced this pull request Oct 2, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2527
5a62577
hswong3i added a commit to alvistack/docker-fisheye that referenced this pull request Oct 2, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2527
a89f462
hswong3i added a commit to alvistack/docker-dnsmasq that referenced this pull request Oct 2, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2527
7760052
hswong3i added a commit to alvistack/docker-jira that referenced this pull request Oct 2, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2527
ec10827
hswong3i added a commit to alvistack/docker-mariadb that referenced this pull request Oct 2, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2527
edc3914
hswong3i added a commit to alvistack/docker-httpd that referenced this pull request Oct 2, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2527
6a82223
hswong3i added a commit to alvistack/docker-openjdk that referenced this pull request Oct 2, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2527
94299a2
hswong3i added a commit to alvistack/docker-node that referenced this pull request Oct 2, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2527
5d0e5b1
hswong3i added a commit to alvistack/docker-mitmproxy that referenced this pull request Oct 2, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2527
6bec8fc
hswong3i added a commit to alvistack/docker-postfix that referenced this pull request Oct 2, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2527
23cb33a
hswong3i added a commit to alvistack/docker-opensuse that referenced this pull request Oct 2, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2527
45eb7ce
hswong3i added a commit to alvistack/docker-golang that referenced this pull request Oct 2, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2527
2aeec65
hswong3i added a commit to alvistack/docker-php-fpm that referenced this pull request Oct 2, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2527
50e23b1
hswong3i added a commit to alvistack/vagrant-ceph that referenced this pull request Oct 2, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2527
e70f368
hswong3i added a commit to alvistack/docker-postgres that referenced this pull request Oct 2, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2527
b884803
hswong3i added a commit to alvistack/vagrant-debian that referenced this pull request Oct 2, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2527
cdbbb92
hswong3i added a commit to alvistack/docker-python that referenced this pull request Oct 2, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2527
5c8f424
hswong3i added a commit to alvistack/docker-ubuntu that referenced this pull request Oct 2, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2527
6264a8b
hswong3i added a commit to alvistack/vagrant-devel that referenced this pull request Oct 2, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2527
c1e7b8d
hswong3i added a commit to alvistack/vagrant-centos that referenced this pull request Oct 2, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2527
2d3979a
hswong3i added a commit to alvistack/docker-rhel that referenced this pull request Oct 2, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2527
5271dd0
hswong3i added a commit to alvistack/vagrant-opensuse that referenced this pull request Oct 2, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2527
074f96c
hswong3i added a commit to alvistack/vagrant-kubernetes that referenced this pull request Oct 2, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2527
a2f5e24
hswong3i added a commit to alvistack/vagrant-rhel that referenced this pull request Oct 2, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2527
f913bd9
hswong3i added a commit to alvistack/vagrant-ubuntu that referenced this pull request Oct 2, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2527
21adba0
hswong3i added a commit to alvistack/vagrant-fedora that referenced this pull request Oct 2, 2022
@hswong3i
https://github.com/ansible/ansible-lint/pull/2527
b37c449
@hswong3i hswong3i mentioned this pull request Oct 2, 2022
Closed
@hswong3i
Copy link
Contributor

hswong3i commented Oct 3, 2022

@ssbarnea refer to #2537, shall we exclude raw from this short hand rule?

ssbarnea added a commit to ssbarnea/ansible-lint that referenced this pull request Oct 5, 2022
@ssbarnea
Add no-shorthand rule as experimental (ansible#2527)
620cdd2 
Fixes: ansible#2117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@audgirka audgirka Awaiting requested review from audgirka audgirka is a code owner automatically assigned from ansible/devtools

@trishnaguha trishnaguha Awaiting requested review from trishnaguha trishnaguha is a code owner automatically assigned from ansible/devtools

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo priyamsahoo is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

no-shorthand: Disallow = style argument defintion
2 participants
@ssbarnea @hswong3i