Allow additional collections in only-builtins

[evgeni]

No description provided.

[evgeni]

I do not exactly understand why it fails on MacOS.

[evgeni]

@ssbarnea can/will you investigate the macOS errors, or should I try to? (I don't have macOS here, so will have to fall back to abusing GH actions 😿 )

[ssbarnea]

@ssbarnea can/will you investigate the macOS errors, or should I try to? (I don't have macOS here, so will have to fall back to abusing GH actions 😿 )

The bad news is that I do have MacOS and I am not able to reproduce the error locally. Feel free to abuse them as much as you need.

[evgeni]

Okay, so the error on macOS is:

syntax-check[specific]: couldn't resolve module/action 'fake_namespace.fake_collection.fake_module'. This often indicates a misspelling, missing collection, or incorrect module path.

I don't exactly understand why it resolves fine on Linux but not on macOS, but I will try to explicitly add it to the mocked list in the config.

Edit: okay, I am 100% puzzled by the configuration loader.

• in test_only_builtin_fail we explicitly use --config-file=/dev/null yet the tests passes correctly -- I bet it fails on syntax tho, not on only-builtins and only passes because assert "only-builtins" in result.stdout also matches the filename 🤦‍♀️ -- I've split out the fix for that into Fix only builtins fail test #2719
• test_only_builtins_allow_collections should have also failed on Linux, as the "old" config didn't contain any mock_modules and the global .ansible-lint that has it set should not be loaded (as we passed a custom config)

[evgeni]

This is now green and ready. I still don't understand why it didn't fail on Linux (IMHO it should), but I also don't strictly care, now that it has been taken care of.