Fix only builtins fail test #2719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
force-pushed
the
builtins-fail-test
branch
2 times, most recently
from
b0b65cd
to
397ad6f
Compare
ssbarnea
approved these changes
Nov 23, 2022
With `config-file=/dev/null` the linting fails with `syntax-check[specific]` and the only-builtins part is never executed. Use the global config which properly mocks the fake collection and assert we raised a warning, not a failure. Fixes: 6e31f19
evgeni
force-pushed
the
builtins-fail-test
branch
from
4c570c8
to
2a32d3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
config-file=/dev/nullthe linting fails withsyntax-check[specific]and the only-builtins part is never executed.Use the global config which properly mocks the fake collection and assert we raised a warning, not a failure.
Fixes: 6e31f19