Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend fqcn rule to complain on collections keyword #2825

Merged
merged 1 commit into from Jan 20, 2023
Merged

Extend fqcn rule to complain on collections keyword #2825

merged 1 commit into from Jan 20, 2023

Conversation

jcgruenhage
Copy link
Contributor

@jcgruenhage jcgruenhage commented Dec 15, 2022 •
edited

I had opened a discussion about this a month ago (#2728), but since there's no interaction happening there I'm opening a PR.

@jcgruenhage jcgruenhage requested review from a team as code owners December 15, 2022 11:00
@cidrblock
Copy link
Contributor

This is awesome. TY

cidrblock
cidrblock approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@cidrblock cidrblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test would be cool here

@jcgruenhage
Copy link
Contributor Author

@cidrblock thanks for the feedback. I've changed the message based on it and extended the test case to also cover this.

@jcgruenhage
Copy link
Contributor Author

Rebased on top of main to re-run CI. The failures weren't related to the PR, just timeouts when talking to galaxy.ansible.com. Would it be possible to add some retries to those calls, so that a single timeout doesn't fail a whole CI job?

@ssbarnea
Copy link
Member

@jcgruenhage I know that galaxy unreliability is a PITA and I already did some work to reduce its use, still I was not able to fully de-couple it, especially as it is impossible to install roles offline.

@jcgruenhage
Copy link
Contributor Author

Well, but CI passed this time, so it's all good I suppose :D

For merging, it's missing those two pending reviews I'd assume?

@jcgruenhage
Copy link
Contributor Author

@ssbarnea anything still needed here? I'd like to see this merged at some point.

@ssbarnea ssbarnea changed the title feat: extend fqcn rule to complain on collections keyword Extend fqcn rule to complain on collections keyword Jan 20, 2023
@ssbarnea ssbarnea merged commit 6087f67 into ansible:main Jan 20, 2023
@jcgruenhage jcgruenhage deleted the ban-collections-keyword branch January 20, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea approved these changes

@ganeshrn ganeshrn ganeshrn approved these changes

@cidrblock cidrblock cidrblock approved these changes

@audgirka audgirka Awaiting requested review from audgirka audgirka is a code owner automatically assigned from ansible/devtools

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo priyamsahoo is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jcgruenhage @cidrblock @ssbarnea @ganeshrn