Complete schema for Antsibull changelogs #2834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shatakshiiii
requested review from
a team,
ssbarnea,
audgirka and
priyamsahoo
|
@felixfontein Any chance you can check this one? Is the new scheme working as expected? |
ssbarnea
requested changes
Dec 16, 2022
There was a problem hiding this comment.
Few observations remarked by @felixfontein 👍
- missing known_issues
- missing trivial category
- I see various markdownDescription fields containing a leading space
- "Value of
short_description from pluginDOCUMENTATION`." - is missing one backquote - a lot of duplication, fields that are the same should never be duplicated inside the file and references should be used instead.
shatakshiiii
force-pushed
the
add_changelog_schema
branch
from
c55b825
to
e0e7f75
Compare
for more information, see https://pre-commit.ci
ssbarnea
changed the title
ssbarnea
force-pushed
the
add_changelog_schema
branch
5 times, most recently
from
c2fc787
to
1f6896b
Compare
ssbarnea
force-pushed
the
add_changelog_schema
branch
from
1f6896b
to
79e6d3f
Compare
ssbarnea
force-pushed
the
add_changelog_schema
branch
from
79e6d3f
to
4e01811
Compare
felixfontein
approved these changes
Dec 17, 2022
|
@shatakshiiii @ssbarnea thanks for improving the schema! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #2814