Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix print leak with meta-unsupported-ansible #2913

Merged
merged 1 commit into from Jan 18, 2023
Merged

Fix print leak with meta-unsupported-ansible #2913

merged 1 commit into from Jan 18, 2023

Conversation

ssbarnea
Copy link
Member

Fixes: #2908

@ssbarnea ssbarnea requested review from a team as code owners January 18, 2023 15:09
@github-actions github-actions bot added the bug label Jan 18, 2023
@ssbarnea
Fix print leak with meta-unsupported-ansible
d2ad198 
- also removes several other undesired prints
- adds preventive measure (flake8-print)

Fixes: #2908
cidrblock
cidrblock approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@cidrblock cidrblock left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10000000000000 for the flake8-print add

@ssbarnea ssbarnea merged commit 5a5a47f into main Jan 18, 2023
@ssbarnea ssbarnea deleted the fix/print branch January 18, 2023 16:06
@kpfleming
Copy link

Wow, print was all over the place!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cidrblock cidrblock cidrblock approved these changes

@audgirka audgirka Awaiting requested review from audgirka audgirka is a code owner automatically assigned from ansible/devtools

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo priyamsahoo is a code owner automatically assigned from ansible/devtools

@shatakshiiii shatakshiiii Awaiting requested review from shatakshiiii shatakshiiii is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

meta-unsupported-ansible rule produces extraneous output
3 participants
@ssbarnea @kpfleming @cidrblock