Change treatment of files that fail to load structured data #2919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
force-pushed
the
fix/invalid-files
branch
from
56680da
to
42f2943
Compare
This new approach should allow us to cache the result of the failed attempt to load structured data on a Lintable. The exception is stored inside the object, so we can later produce detailed errors.
ssbarnea
force-pushed
the
fix/invalid-files
branch
from
42f2943
to
201d5df
Compare
cidrblock
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new approach should allow us to cache the result of the failed
attempt to load structured data on a Lintable. The exception is stored
inside the object, so we can later produce detailed errors.