Ignore args rule finding if value for choice has jinja template #2929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klaus-tux
changed the title
|
@klaus-tux Thanks for fixing this. I checked your code and looks to do exactly what I would have done myself. The only issue I have is that I see a slight reducing of code coverage reported by codecov. If you can have a look at that it would be awesome. BTW, you can ignore the "eco" job failure, it is normal to fail sometimes. |
|
Hi @ssbarnea ! Thank you for your feedback :-) I added a correctly failing test and now all new lines are covered completely. Please ping me if something else is needed. |
|
@klaus-tux small typo ;) |
|
@ssbarnea Thanks for the heads-up. I learned the lesson: Run the linters before committing... Sorry for the delay. |
ssbarnea
approved these changes
Jan 24, 2023
ssbarnea
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggest to ignore the args[module] rule finding for
"value of %s must be one of: %s, got: %s"completely if the value contains a jinja template. This fixes #2866 .This is consistent to ignoring type check errors if they contain jinja templates. I copied the code from this check. Unfortunately, there is no failing test if this check is omitted. So I did not refactor the duplication any further, because I'm rather new to Python development. Feel free to improve :-)