Remove rich markdown header override #2938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
force-pushed
the
chore/coverage2
branch
from
feea1ca
to
6d7c711
Compare
As rich 13.2 is changing internals related to markdown rendering, it is better to remove our custom header rendering override, so users can use the library with any version of rich.
ssbarnea
force-pushed
the
chore/coverage2
branch
from
6d7c711
to
ef1c33b
Compare
cidrblock
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As rich 13.2.0 is changing internals related to markdown rendering, it is better to remove our custom header rendering override, so users can use the library with any version of rich.
The bug was observed by mypy which noted the internal changes in newer rich, as they do not pin these dependencies.
Related: Textualize/rich#2137
Related: Textualize/rich#2413