Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow noqa comments without colons #2971

Merged
merged 1 commit into from Feb 2, 2023
Merged

Allow noqa comments without colons #2971

merged 1 commit into from Feb 2, 2023

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Feb 2, 2023

Fixes: #2970

@ssbarnea ssbarnea requested review from a team as code owners February 2, 2023 14:30
@github-actions github-actions bot added the bug label Feb 2, 2023
cidrblock
cidrblock approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@cidrblock cidrblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect

@ssbarnea ssbarnea changed the title Allow noqa comments without colons Allow noqa comments without colons (#2971 Feb 2, 2023
@ssbarnea ssbarnea merged commit 0206ddf into main Feb 2, 2023
@ssbarnea ssbarnea deleted the fix/noqa branch February 2, 2023 15:17
@ssbarnea ssbarnea changed the title Allow noqa comments without colons (#2971 Allow noqa comments without colons Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cidrblock cidrblock cidrblock approved these changes

@audgirka audgirka Awaiting requested review from audgirka audgirka is a code owner automatically assigned from ansible/devtools

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo priyamsahoo is a code owner automatically assigned from ansible/devtools

@shatakshiiii shatakshiiii Awaiting requested review from shatakshiiii shatakshiiii is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6.12.0 does not obey some noqa comment tags
2 participants
@ssbarnea @cidrblock