Rename meta-unsupported-ansible to meta-runtime and correct its logic #3000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entifier in runtime.yml and refactoring
ssbarnea
changed the title
ssbarnea
force-pushed
the
meta_runtime_rule_extend
branch
from
8c5707f
to
8afcc94
Compare
ssbarnea
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring and renaming
meta-unsupported-ansible ruletometa-runtimefor a more accurate name.Added SpecifierSet (valid version with operators) check for the
requires_ansiblekey value. This will verify that the version value is a valid version under Pythonic requirements.Examples:
Valid:
Invalid:
Added documentation of this to the rule .md file and renamed .md file to
meta-runtime.mdto match.Fixes #2999