Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve loop-var-prefix checking #3041

Merged
merged 1 commit into from Feb 15, 2023
Merged

Improve loop-var-prefix checking #3041

merged 1 commit into from Feb 15, 2023

Conversation

ssbarnea
Copy link
Member

Fixes: #2838

@ssbarnea ssbarnea requested review from a team as code owners February 15, 2023 15:20
@github-actions github-actions bot added the bug label Feb 15, 2023
@ssbarnea ssbarnea changed the title Relax loop-var-prefix checking Improve loop-var-prefix checking Feb 15, 2023
@ssbarnea ssbarnea added this to the 6.13.x milestone Feb 15, 2023
cidrblock
cidrblock approved these changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@cidrblock cidrblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

__nice

@ssbarnea ssbarnea merged commit c7a1eed into main Feb 15, 2023
@ssbarnea ssbarnea deleted the fix/loop-var-prefix branch February 15, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cidrblock cidrblock cidrblock approved these changes

@audgirka audgirka Awaiting requested review from audgirka audgirka is a code owner automatically assigned from ansible/devtools

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo priyamsahoo is a code owner automatically assigned from ansible/devtools

@shatakshiiii shatakshiiii Awaiting requested review from shatakshiiii shatakshiiii is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
6.13.x
Development

Successfully merging this pull request may close these issues.

loop-var-prefix rule breaks COP rule 3.1.4
2 participants
@ssbarnea @cidrblock