New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow custom rules specific configuration with ansible-lint-config JSON Schema #3080
Merged
ssbarnea
merged 9 commits into
ansible:main
from
ssato:fix/allow-custom-rules-configuration
Mar 2, 2023
Merged
Allow custom rules specific configuration with ansible-lint-config JSON Schema #3080
ssbarnea
merged 9 commits into
ansible:main
from
ssato:fix/allow-custom-rules-configuration
Mar 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssato
force-pushed
the
fix/allow-custom-rules-configuration
branch
2 times, most recently
from
February 22, 2023 18:12
fe4c8d3
to
520d1e6
Compare
The schema for .ansible-lint is too strict and only allows rules specific confgurations of the default rules listed in it. This change removes that limitation and allows custom rules specific configurations.
ssato
force-pushed
the
fix/allow-custom-rules-configuration
branch
from
February 24, 2023 15:30
e3f149e
to
4ab329e
Compare
ssbarnea
requested changes
Feb 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not remove the enum as that is very useful for providing auto-complete in editors. You can address you problem by using oneOf
that includes the enum first and your string pattern second.
audgirka
force-pushed
the
fix/allow-custom-rules-configuration
branch
from
March 1, 2023 11:59
d6f4d20
to
4ab329e
Compare
ssbarnea
changed the title
Fix: Loosen the schema for .ansible-lint to allow custom rules specific configuration
Allow custom rules specific configuration with ansible-lint-config JSON Schema
Mar 2, 2023
ssbarnea
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The schema for .ansible-lint is too strict and only allows rules specific configurations of the default rules listed in it.
The changes remove that too strict limitation of the schema and allows custom rules specific configuration.