Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom rules specific configuration with ansible-lint-config JSON Schema #3080

Merged
merged 9 commits into from Mar 2, 2023

Conversation

ssato
Copy link
Contributor

@ssato ssato commented Feb 22, 2023

The schema for .ansible-lint is too strict and only allows rules specific configurations of the default rules listed in it.

The changes remove that too strict limitation of the schema and allows custom rules specific configuration.

@ssato ssato requested review from a team as code owners February 22, 2023 15:44
@github-actions github-actions bot added the bug label Feb 22, 2023
@ssato ssato force-pushed the fix/allow-custom-rules-configuration branch 2 times, most recently from fe4c8d3 to 520d1e6 Compare February 22, 2023 18:12
@ssato ssato force-pushed the fix/allow-custom-rules-configuration branch from e3f149e to 4ab329e Compare February 24, 2023 15:30
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not remove the enum as that is very useful for providing auto-complete in editors. You can address you problem by using oneOf that includes the enum first and your string pattern second.

@audgirka audgirka force-pushed the fix/allow-custom-rules-configuration branch from d6f4d20 to 4ab329e Compare March 1, 2023 11:59
@ssbarnea ssbarnea self-requested a review March 1, 2023 18:11
@ssbarnea ssbarnea changed the title Fix: Loosen the schema for .ansible-lint to allow custom rules specific configuration Allow custom rules specific configuration with ansible-lint-config JSON Schema Mar 2, 2023
@ssbarnea ssbarnea merged commit 5b070f0 into ansible:main Mar 2, 2023
@ssato ssato deleted the fix/allow-custom-rules-configuration branch March 2, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants