Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document fix for literal_compare == False #3207

Merged
merged 2 commits into from Mar 24, 2023
Merged

Conversation

jemand771
Copy link
Contributor

While this should be obvious to experienced ansible users, I didn't know you could just use the not keyword like that. Documenting this doesn't take up much extra space but can potentially save time wihle fixing linter warnings.

While this should be obvious to experienced ansible users,
I didn't know you could just use the `not` keyword like that.
Documenting this doesn't take up much extra space but can
potentially save time wihle fixing linter warnings.
@jemand771
Copy link
Contributor Author

jemand771 commented Mar 22, 2023

I haven't built this since it's a very small change and nothing should really break.

Feel free to close this if you feel like it adds too much noise

edit: oh well, looks like something did break. I'll look at this later

@4ch1m
Copy link
Contributor

4ch1m commented Mar 23, 2023

I haven't built this since it's a very small change and nothing should really break.

Feel free to close this if you feel like it adds too much noise

edit: oh well, looks like something did break. I'll look at this later

I don't think the errors are caused by your PR.
One of my PRs also fails due to the same problems.

I believe it has something to do with these changes: #3117

I've spent quite some time to understand what's going on; trying to fix it.
No luck so far. 😢

Maybe @ssbarnea can help us out.

@4ch1m
Copy link
Contributor

4ch1m commented Mar 23, 2023

I've spent quite some time to understand what's going on; trying to fix it. No luck so far. cry

Maybe @ssbarnea can help us out.

I found the root cause of the issue.

The store.json is under version control and part of the unit-tests.

The file holds several ETags of GitHub-server-files/-resources.

IMHO this is not suitable for unit-tests, since ETags are - per definition - non-deterministic (check: ETag).

Meaning: It's up to the server(-implementation) how ETags are being generated; and how/if they change over time.

@ssbarnea : Maybe we should find a workaround for this?

@jemand771
Copy link
Contributor Author

ah, thanks for looking into that! I couldn't really figure out what was frong at first glance.
I just saw something about failed schemas and thought that maybe help texts are only allowed to one paragraph long or something like that, but apparently that's not it

@ssbarnea ssbarnea changed the title document fix for literal_compare == False Document fix for literal_compare == False Mar 24, 2023
@ssbarnea ssbarnea added the bug label Mar 24, 2023
@ssbarnea ssbarnea marked this pull request as ready for review March 24, 2023 12:54
@ssbarnea ssbarnea requested review from a team as code owners March 24, 2023 12:54
@ssbarnea ssbarnea merged commit 33de6bc into ansible:main Mar 24, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants