-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ansible-lint 6.17.0 does not find any issues on full repo #3516
Comments
Seems like it may be related to this collection: When I have this collection in my /collections/ansible_collections folder in the repo, ansible-lint returns 0 failures and warnings. If I exclude this folder, like I intend to do with all collections except internally developed ones, then it returns the several hundred failure and warnings I expect. if I try to scan only this folder, it returns 0 failures and shows only 1 file
|
Look at line "INFO Loading ignores from collections/ansible_collections/netapp_eseries/santricity/.gitignore" -- check the content of the file and you will likely find the reason why all those files were excluded. |
I don't understand? ansible-lint looked through subfolders, found other .gitignores nested inside of folders and then ansible-lint ignored any files it found there? If anything I would expect that to only impact git and not ansible-lint, but looking at the contents, I don't see why it would cause ansible-lint to still look through the files, but report no issues.
|
I will look at it tomorrow, yep, that content should not cause it to ignore. Since 6.17.0, all git ignores are loaded by default, recursively, regardless if that is a git repository or not. Do you also have some exclude paths in linter own config? |
In my Example:
|
If you cannot share the repo with the problem, please create one similar public repo where the problem can be reproduced. Once we reproduce it, we will be able to fix it, especially as this is a high impact issue. |
Please try this repo: When I run |
Was the repo helpful? |
I think that the bug is caused by some deep |
Summary
After installing 6.17.0, it scans all files in my directory/repo, but reports 0 failures and 0 warnings when there are known issues in the repo
Issue Type
OS / ENVIRONMENT
ansible-lint 6.17.0 using ansible-core:2.14.6 ruamel-yaml:None ruamel-yaml-clib:None
RHEL 8 and Ubuntu 22.04
STEPS TO REPRODUCE
Run only
ansible-lint
against a repo with 1300+ files, with and without excluding acollections
folder.Desired Behavior
using only
ansible-lint
with .ansible-lint file based on the sample file, all valid errors are shown for all foldersActual Behavior
Previous to 6.12, 300+ failures would be detected. 6.12.2 had the issue where it was not excluding directories and also caused a fatal error that prevented it from doing a full run. 6.14 is taking the appropriate time to scan all of the files as expected, but returns 0 issues when we have not addressed all that were previously present.
When using
ansible-lint foldername
it scans just that folder and finds valid issues with files. Unable to determine exactly what causes it to fail to detect when scanning the entire repo, and no errors are shown in standard modePlease give some details of what is happening.
Include a minimum complete verifiable example with:
ansible-playbook --syntax-check playbook
Subset of verbose output below
The text was updated successfully, but these errors were encountered: