Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document autofix ability for rules that supports it #3791

Merged
merged 1 commit into from Sep 29, 2023
Merged

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Sep 29, 2023

In addition to adding a notice on each rule that supports autofix, we also check if we had any rule advertising autofix but failing to mention it inside its documentation.

Partial: #3624
Closes: #3786
Closes: #3788

In addition to adding a notice on each rule that supports autofix,
we also check if we had any rule advertising autofix but failing
to mention it inside its documentation.
@ssbarnea ssbarnea requested review from a team as code owners September 29, 2023 13:03
@ssbarnea ssbarnea temporarily deployed to ack September 29, 2023 13:03 — with GitHub Actions Inactive
@ssbarnea ssbarnea added the bug label Sep 29, 2023
@ssbarnea ssbarnea temporarily deployed to ack September 29, 2023 13:03 — with GitHub Actions Inactive
@ssbarnea ssbarnea merged commit 54cf3ea into main Sep 29, 2023
23 checks passed
@ssbarnea ssbarnea deleted the fix/docs branch September 29, 2023 13:16
nrdufour added a commit to nrdufour/home-ops that referenced this pull request Oct 3, 2023
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [ansible-lint](https://github.com/ansible/ansible-lint) ([changelog](https://github.com/ansible/ansible-lint/releases)) | patch | `==6.20.1` -> `==6.20.2` |

---

### ⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the logs for more information.

---

### Release Notes

<details>
<summary>ansible/ansible-lint (ansible-lint)</summary>

### [`v6.20.2`](https://github.com/ansible/ansible-lint/releases/tag/v6.20.2)

[Compare Source](ansible/ansible-lint@v6.20.1...v6.20.2)

#### Bugfixes

-   Do not use github action path for running ansible lint ([#&#8203;3798](ansible/ansible-lint#3798)) [@&#8203;ReenigneArcher](https://github.com/ReenigneArcher)
-   Correct listing of autofix rules in documentation ([#&#8203;3797](ansible/ansible-lint#3797)) [@&#8203;ssbarnea](https://github.com/ssbarnea)
-   Make the autofix rule list dynamic in documentation ([#&#8203;3785](ansible/ansible-lint#3785)) [@&#8203;shatakshiiii](https://github.com/shatakshiiii)
-   Fix documentation links to autofix page ([#&#8203;3796](ansible/ansible-lint#3796)) [@&#8203;ssbarnea](https://github.com/ssbarnea)
-   Bump test dependencies ([#&#8203;3795](ansible/ansible-lint#3795)) [@&#8203;ssbarnea](https://github.com/ssbarnea)
-   Correct documentation regarding CLI argument precedence ([#&#8203;3792](ansible/ansible-lint#3792)) [@&#8203;ssbarnea](https://github.com/ssbarnea)
-   Document autofix ability for rules that supports it ([#&#8203;3791](ansible/ansible-lint#3791)) [@&#8203;ssbarnea](https://github.com/ssbarnea)
-   Accept underline prefix when checking var-naming ([#&#8203;3789](ansible/ansible-lint#3789)) [@&#8203;ssbarnea](https://github.com/ssbarnea)
-   Correct regression with use of --fix ([#&#8203;3783](ansible/ansible-lint#3783)) [@&#8203;ssbarnea](https://github.com/ssbarnea)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xLjMiLCJ1cGRhdGVkSW5WZXIiOiIzNy4xLjMiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=-->

Reviewed-on: https://git.home/nrdufour/home-ops/pulls/123
Co-authored-by: Renovate <renovate@ptinem.io>
Co-committed-by: Renovate <renovate@ptinem.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants