Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backward compatibility #3929

Merged
merged 1 commit into from Dec 6, 2023
Merged

Fix backward compatibility #3929

merged 1 commit into from Dec 6, 2023

Conversation

McSim85
Copy link
Contributor

@McSim85 McSim85 commented Dec 5, 2023

Any versions before this PR #3762 (v6.22.1) use the main branch for requirements-lock.txt. (full url https://raw.githubusercontent.com/ansible/ansible-lint/main/.config/requirements-lock.txt)
It still uses the main branch even if you specify a particular version.
For example, this config

name: ansible-lint
on: [pull_request]

jobs:
  build:
    name: Ansible Lint # Naming the build is important to use it as a status check
    runs-on: ubuntu-latest
    steps:
      - name: Checkout Code
        uses: actions/checkout@v2
      - name: Run ansible-lint
        uses: ansible/ansible-lint@v6.20.0

will try to download the main branch:

Run wget --output-file=.git/ansible-lint-requirements.txt https://raw.githubusercontent.com/ansible/ansible-lint/main/.config/requirements-lock.txt
  wget --output-file=.git/ansible-lint-requirements.txt https://raw.githubusercontent.com/ansible/ansible-lint/main/.config/requirements-lock.txt
  shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
Error: Process completed with exit code 8.

The PR that broke backward compatibility is this one #3925

Fixes: #3928

7fa5f76

@McSim85 McSim85 requested a review from a team as a code owner December 5, 2023 14:44
@McSim85 McSim85 requested review from priyamsahoo and shatakshiiii and removed request for a team December 5, 2023 14:44
@McSim85
Copy link
Contributor Author

McSim85 commented Dec 5, 2023

I basically made a symlink

➜  .config git:(main) ls -l | grep  requirements | grep lock                                                                                                                                                                                                                                              
-rw-r--r--  1 user  staff  1014 Dec  5 15:36 lock-requirements.txt
lrwxr-xr-x  1 user  staff    21 Dec  5 15:37 requirements-lock.txt -> lock-requirements.txt

@audgirka
Copy link
Contributor

audgirka commented Dec 6, 2023

@ssbarnea I think, we should update the file name for wget to lock-requirements.txt instead of requirements-lock.txt.
As this is adding requirements-lock.txt and referencing lock-requirements.txt inside of it

@McSim85
Copy link
Contributor Author

McSim85 commented Dec 6, 2023

@ssbarnea I think, we should update the file name for wget to lock-requirements.txt instead of requirements-lock.txt. As this is adding requirements-lock.txt and referencing lock-requirements.txt inside of it

@ajinkyau
It's just a symlink. To be honest, I don't know why GitHub represents symlinks in that way:

adding requirements-lock.txt and referencing lock-requirements.txt inside of it`.

But if you pull my changes to your local machine, you will see it's a symlink:

$ .config git:(main) ls -l | grep  requirements | grep lock                                                                                                                                                                                                                                                 
-rw-r--r--  1 user  staff  1014 Dec  5 15:36 lock-requirements.txt
lrwxr-xr-x  1 user  staff    21 Dec  5 15:37 requirements-lock.txt -> lock-requirements.txt

note: requirements-lock.txt -> lock-requirements.txt

@McSim85
Copy link
Contributor Author

McSim85 commented Dec 6, 2023

Okey, this view represents better, what I just did
https://github.com/ansible/ansible-lint/tree/b366542caffa261d19a02d87d61731a477c7074c/.config

image

@audgirka audgirka merged commit ff74132 into ansible:main Dec 6, 2023
24 checks passed
nrdufour added a commit to nrdufour/home-ops that referenced this pull request Jan 20, 2024
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [ansible-lint](https://github.com/ansible/ansible-lint) ([changelog](https://github.com/ansible/ansible-lint/releases)) | patch | `==6.22.1` -> `==6.22.2` |

---

### Release Notes

<details>
<summary>ansible/ansible-lint (ansible-lint)</summary>

### [`v6.22.2`](https://github.com/ansible/ansible-lint/releases/tag/v6.22.2)

[Compare Source](ansible/ansible-lint@v6.22.1...v6.22.2)

#### Bugfixes

-   Fix key error for name\[casing] rule ([#&#8203;3987](ansible/ansible-lint#3987)) [@&#8203;ajinkyau](https://github.com/ajinkyau)
-   Allow dashes in legacy role namespaces ([#&#8203;3962](ansible/ansible-lint#3962)) [@&#8203;sur5r](https://github.com/sur5r)
-   Use new ansible-compat verbosity levels ([#&#8203;3975](ansible/ansible-lint#3975)) [@&#8203;ssbarnea](https://github.com/ssbarnea)
-   Remove dependency on newer requests library ([#&#8203;3959](ansible/ansible-lint#3959)) [@&#8203;ssbarnea](https://github.com/ssbarnea)
-   Ignore set-property for systemd command ([#&#8203;3949](ansible/ansible-lint#3949)) [@&#8203;alanbbr](https://github.com/alanbbr)
-   Correct requires_ansible error message ([#&#8203;3954](ansible/ansible-lint#3954)) [@&#8203;ssbarnea](https://github.com/ssbarnea)
-   Improve transformation for `no-free-form` rule ([#&#8203;3945](ansible/ansible-lint#3945)) [@&#8203;ajinkyau](https://github.com/ajinkyau)
-   Documentation improvement ([#&#8203;3946](ansible/ansible-lint#3946)) [@&#8203;ssbarnea](https://github.com/ssbarnea)
-   docs: fix grammatical issue in philosophy Q\&A section ([#&#8203;3934](ansible/ansible-lint#3934)) [@&#8203;davidhulick](https://github.com/davidhulick)
-   Update supported versions of ansible ([#&#8203;3930](ansible/ansible-lint#3930)) [@&#8203;ajinkyau](https://github.com/ajinkyau)
-   Fix backward compatibility ([#&#8203;3929](ansible/ansible-lint#3929)) [@&#8203;McSim85](https://github.com/McSim85)
-   Fix auto capitalization for name\[prefix] rule ([#&#8203;3922](ansible/ansible-lint#3922)) [@&#8203;ajinkyau](https://github.com/ajinkyau)
-   Fix role deps check for detecting path names ([#&#8203;3923](ansible/ansible-lint#3923)) [@&#8203;cavcrosby](https://github.com/cavcrosby)
-   Avoid warnings about PATH with pipx installations ([#&#8203;3920](ansible/ansible-lint#3920)) [@&#8203;ssbarnea](https://github.com/ssbarnea)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNDAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE0MC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Reviewed-on: https://git.home/nrdufour/home-ops/pulls/319
Co-authored-by: Renovate <renovate@ptinem.io>
Co-committed-by: Renovate <renovate@ptinem.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
2 participants