Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scenario when role has no dependencies section in meta/main.yml #3993

Merged
merged 20 commits into from Jan 29, 2024

Conversation

audgirka
Copy link
Contributor

Fixes scenario for no role dependencies

Fixes #3991

@audgirka audgirka requested a review from a team as a code owner January 22, 2024 08:16
@audgirka audgirka requested review from cristianonicolai and shatakshiiii and removed request for a team January 22, 2024 08:16
@github-actions github-actions bot added the bug label Jan 22, 2024
@ssbarnea
Copy link
Member

@ajinkyau I think that the issue might be related to accidental use ANSI instead of UTF-8. Probably we forgot to pass encoding parameter somewhere, maybe on subprocess.run?

@audgirka audgirka merged commit c87060a into main Jan 29, 2024
23 checks passed
@audgirka audgirka deleted the fix/no_role_deps branch January 29, 2024 09:06
nrdufour added a commit to nrdufour/home-ops that referenced this pull request Feb 7, 2024
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [ansible-lint](https://github.com/ansible/ansible-lint) ([changelog](https://github.com/ansible/ansible-lint/releases)) | major | `==6.22.2` -> `==24.2.0` |

---

### Release Notes

<details>
<summary>ansible/ansible-lint (ansible-lint)</summary>

### [`v24.2.0`](https://github.com/ansible/ansible-lint/releases/tag/v24.2.0)

[Compare Source](ansible/ansible-lint@v6.22.2...v24.2.0)

#### Minor Changes

-   Drop support for Python 3.9 ([#&#8203;4009](ansible/ansible-lint#4009)) [@&#8203;audgirka](https://github.com/audgirka)

#### Bugfixes

-   Fix scenario when role has no `dependencies` section in `meta/main.yml` ([#&#8203;3993](ansible/ansible-lint#3993)) [@&#8203;audgirka](https://github.com/audgirka)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Reviewed-on: https://git.home/nrdufour/home-ops/pulls/367
Co-authored-by: Renovate <renovate@ptinem.io>
Co-committed-by: Renovate <renovate@ptinem.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Exception when role metadata has no dependencies key
2 participants