Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest adt installation #4071

Merged
merged 2 commits into from Mar 20, 2024
Merged

Suggest adt installation #4071

merged 2 commits into from Mar 20, 2024

Conversation

audgirka
Copy link
Contributor

No description provided.

@audgirka audgirka requested a review from a team as a code owner March 15, 2024 10:06
@audgirka audgirka requested review from ssbarnea and shatakshiiii and removed request for a team March 15, 2024 10:06
@github-actions github-actions bot added the bug label Mar 15, 2024
@audgirka audgirka added documentation This issue or PR is related to the docs and removed bug labels Mar 15, 2024
@audgirka audgirka added the skip-changelog Can be missed from the changelog. label Mar 15, 2024
@audgirka audgirka marked this pull request as draft March 15, 2024 10:10
@audgirka audgirka marked this pull request as ready for review March 15, 2024 11:41
@ssbarnea ssbarnea closed this Mar 15, 2024
ssbarnea
ssbarnea reviewed Mar 15, 2024
View reviewed changes
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it would look better if we use the blue-info note to highlight the installation as part of adt and keep the rest without. Basically the entire "cassette" should reusable inside all adt projects.

@ssbarnea
Copy link
Member

Also mention jira ticket in PR description.

@tima
Copy link
Contributor

tima commented Mar 18, 2024

lgtm

@audgirka audgirka requested a review from ssbarnea March 20, 2024 09:41
@audgirka audgirka enabled auto-merge (squash) March 20, 2024 09:45
@audgirka audgirka merged commit e91ced9 into main Mar 20, 2024
23 checks passed
@audgirka audgirka deleted the fix/adt_installation branch March 20, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cidrblock cidrblock cidrblock approved these changes

@ariordan-redhat ariordan-redhat ariordan-redhat approved these changes

@shatakshiiii shatakshiiii shatakshiiii approved these changes

@ssbarnea ssbarnea Awaiting requested review from ssbarnea

Assignees
No one assigned
Labels
documentation This issue or PR is related to the docs skip-changelog Can be missed from the changelog.
Projects
🧰 devtools project board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@audgirka @ssbarnea @tima @cidrblock @ariordan-redhat @shatakshiiii