lineinfile not insertafter 'EOF' if line presents in file

[nghnam]

Issue Type: Bug Report

Ansible Version: 1.9.3

Ansible Configuration: default

Environment: Ubuntu 14.04

Summary:

lineinfile won't insert line after EOF if line has presented in file.

Steps To Reproduce:

An example ansible task:

- name: test insertafter EOF
  lineinfile:
    dest: /tmp/test.txt
    line: "{{ item.line }}"
    insertafter: 'EOF'
    state: present
  with_items: 
    - { line: Hello Ansible }

My /tmp/test.txt:

Hello Ansible
=============

Expected Results:

Hello Ansible
=============
Hello Ansible

Actual Results:

TASK: [test insertafter EOF] ************************************************** 
ok: [localhost] => (item={'line': 'Hello Ansible'}) => {"backup": "", "changed": false, "item": {"line": "Hello Ansible"}, "msg": ""}

PLAY RECAP ******************************************************************** 
localhost                  : ok=1    changed=0    unreachable=0    failed=0 

And /tmp/test.txt not changed.

In lineinfile.py,
https://github.com/ansible/ansible-modules-core/blob/devel/files/lineinfile.py#L233

The condition if index[0] != -1: checked regexp matched a line in file, but it did not check regexp is defined or not.
I changed this line into if index[0] != -1 and regexp is not None: and re-executed the playbook. It worked as expected.

[ansibot]

@ansible ping, this issue is waiting for your response.
click here for bot help

[ansibot]

@ansible, ping. This issue is still waiting on your response.
click here for bot help

[ansibot]

@ansible, ping. This issue is still waiting on your response.
click here for bot help

[ansibot]

@ansible, ping. This issue is still waiting on your response.
click here for bot help

[ansibot]

@ansible, ping. This issue is still waiting on your response.
click here for bot help

[ansibot]

@ansible, ping. This issue is still waiting on your response.
click here for bot help

[ansibot]

This repository has been locked. All new issues and pull requests should be filed in https://github.com/ansible/ansible

Please read through the repomerge page in the dev guide. The guide contains links to tools which automatically move your issue or pull request to the ansible/ansible repo.

[ansibot]

This issue was migrated to ansible/ansible#30046