Environment variables templated again

[bretmartin]

@jimi-c #12191 has resurfaced. Please see that issue for a test case, which now fails again.

ansible-playbook --vault-password-file=~/.ansible_vault_password \
                playbook-test-12238.yml --limit=localhost -vvvv
No config file found; using defaults
1 plays in playbook-test-12238.yml
Loaded callback default of type stdout, v2.0

PLAY ***************************************************************************

TASK [setup] *******************************************************************
ESTABLISH LOCAL CONNECTION FOR USER: bam
localhost EXEC (umask 22 && mkdir -p "$HOME/.ansible/tmp/ansible-tmp-1441909260.33-28122013476446" && echo "$HOME/.ansible/tmp/ansible-tmp-1441909260.33-28122013476446")
localhost PUT /var/folders/n7/wrg1c7615892m2qgyv8r_yg00000gn/T/tmpHVzILN TO /Users/bam/.ansible/tmp/ansible-tmp-1441909260.33-28122013476446/setup
localhost EXEC LANG=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 LC_CTYPE=en_US.UTF-8 /usr/bin/python /Users/bam/.ansible/tmp/ansible-tmp-1441909260.33-28122013476446/setup; rm -rf "/Users/bam/.ansible/tmp/ansible-tmp-1441909260.33-28122013476446/" > /dev/null 2>&1
ok: [localhost]
ERROR! template error while templating string: unexpected '|'

[jimi-c]

Sorry about that @bretmartin, I had some logic mistakes related to the split in the facts/non-persistent facts caching from earlier. The above patch should correct this.

Thanks!

[bretmartin]

Confirmed to be fixed again -- thanks.