Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For actionable cb plugin also hide ok for itemized results #14977

Merged
merged 1 commit into from
Mar 21, 2016
Merged

For actionable cb plugin also hide ok for itemized results #14977

merged 1 commit into from
Mar 21, 2016

Conversation

towolf
Copy link
Contributor

@towolf towolf commented Mar 15, 2016

Issue Type:
  • Bugfix Pull Request
Ansible Version:
ansible 2.1.0 (hide_ok_items_in_actionable e51c234dde) last updated 2016/03/15 11:27:35 (GMT +200)
  lib/ansible/modules/core: (devel eef9c54874) last updated 2016/03/14 11:36:44 (GMT +200)
  lib/ansible/modules/extras: (devel be66e9d297) last updated 2016/03/14 11:36:45 (GMT +200)
  config file = /etc/ansible/ansible.cfg
  configured module search path = Default w/o overrides
Summary:

The purpose of the actionable callback plugin is to hide uninteresting
results.

Also hide the ok results when the task was itemized.

Example output:
TASK [template itemized] *******************************************************
changed: [localhost] => (item=[u'baz', u'quux'])
--- before
+++ after: dynamically generated
@@ -0,0 +1 @@
+bar


PLAY RECAP *********************************************************************
localhost                  : ok=4    changed=1    unreachable=0    failed=0

jpic
jpic reviewed Mar 17, 2016
View reviewed changes
lib/ansible/plugins/callback/actionable.py
self.display_task_banner()
self.super_ref.v2_playbook_item_on_ok(result)
else:
pass
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove else: pass ?

@towolf towolf force-pushed the hide_ok_items_in_actionable branch from e51c234 to 319bb0d Compare March 17, 2016 08:58
@towolf
Copy link
Contributor Author

towolf commented Mar 17, 2016

Updated PR to remove extraneous pass condition. Also removed it at the location above where I got it from.

@jpic
Copy link
Contributor

jpic commented Mar 17, 2016

LGTM

@towolf
For actionable cb plugin also hide ok for itemized results
4938b98 
The purpose of the `actionable` callback plugin is to hide uninteresting
results.

Also hide the ok results when the task was itemized.
@towolf towolf force-pushed the hide_ok_items_in_actionable branch from 319bb0d to 4938b98 Compare March 21, 2016 14:02
@towolf
Copy link
Contributor Author

towolf commented Mar 21, 2016

Updated PR, because @jimi-c made a commit that conflicted with mine.

@bcoca bcoca added this to the 2.1.0 milestone Mar 21, 2016
bcoca added a commit that referenced this pull request Mar 21, 2016
@bcoca
Merge pull request #14977 from towolf/hide_ok_items_in_actionable
3ae9a27 
For `actionable` cb plugin also hide ok for itemized results
@bcoca bcoca merged commit 3ae9a27 into ansible:devel Mar 21, 2016
@towolf towolf deleted the hide_ok_items_in_actionable branch March 21, 2016 15:10
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 4, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request.
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@towolf @jpic @bcoca @ansibot