Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow endpoint override in azure_rm module utils #17925

Closed
nitzmahone opened this issue Oct 6, 2016 · 9 comments
Closed

Allow endpoint override in azure_rm module utils #17925

nitzmahone opened this issue Oct 6, 2016 · 9 comments
Labels
affects_2.1 This issue/PR affects Ansible v2.1 affects_2.2 This issue/PR affects Ansible v2.2 affects_2.3 This issue/PR affects Ansible v2.3 azure cloud deprecated This issue/PR relates to a deprecated module. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. support:certified This issue/PR relates to certified code. support:community This issue/PR relates to code supported by the Ansible community.

Comments

@nitzmahone
Copy link
Member

nitzmahone commented Oct 6, 2016

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

azure_rm_common.py

SUMMARY

The current definition of the azure_rm common module utils doesn't allow overriding the various built-in endpoints (auth, table/blob storage, service bus, etc). This will be necessary to allow connection to other Azure instances (eg, AzureChinaCloud, private Azure Stack instances).

The new Python SDK seems to support overriding the endpoints via host_base, so we should add the override capability to the env credential mapping and common module utility code.

List of AzureChinaCloud endpoint URLs is at: Azure/azure-sdk-for-python#284

@nitzmahone nitzmahone added feature_idea azure affects_2.1 This issue/PR affects Ansible v2.1 affects_2.2 This issue/PR affects Ansible v2.2 affects_2.3 This issue/PR affects Ansible v2.3 labels Oct 6, 2016
@ansibot ansibot added module This issue/PR relates to a module. plugin cloud labels Dec 13, 2016
@jimi-c jimi-c removed the plugin label Jan 4, 2017
@ansibot
Copy link
Contributor

ansibot commented Jun 24, 2017

@ansibot ansibot added the support:community This issue/PR relates to code supported by the Ansible community. label Jun 29, 2017
@ansibot
Copy link
Contributor

ansibot commented Jul 19, 2017

@ansibot ansibot added the deprecated This issue/PR relates to a deprecated module. label Sep 15, 2017
@ansibot
Copy link
Contributor

ansibot commented Nov 2, 2017

@yaweiw
Copy link
Contributor

yaweiw commented Nov 3, 2017

@nitzmahone is this issue resolved? I see the one in python sdk is closed.

@ansibot ansibot added the needs_maintainer Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml) label Nov 11, 2017
@ansibot
Copy link
Contributor

ansibot commented Nov 19, 2017

@ansibot ansibot added support:certified This issue/PR relates to certified code. and removed needs_maintainer Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml) labels Nov 19, 2017
@ZhijunZhao
Copy link
Contributor

@nitzmahone I think this issue can be closed, for it's duplicated one is closed.

@kyliel
Copy link
Contributor

kyliel commented Jan 22, 2018

@nitzmahone Is this related to new inventory plugin mechanism? Let us discuss in this week meeting.

@ansibot
Copy link
Contributor

ansibot commented Jan 22, 2018

@yuwzho
Copy link
Contributor

yuwzho commented Jan 23, 2018

bug_resolved

@ansibot ansibot closed this as completed Jan 23, 2018
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_idea labels Mar 2, 2018
@ansible ansible locked and limited conversation to collaborators Apr 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.1 This issue/PR affects Ansible v2.1 affects_2.2 This issue/PR affects Ansible v2.2 affects_2.3 This issue/PR affects Ansible v2.3 azure cloud deprecated This issue/PR relates to a deprecated module. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. support:certified This issue/PR relates to certified code. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

No branches or pull requests

7 participants