Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide MDT Dynamic Inventory script #18352

Merged
merged 4 commits into from Nov 7, 2016
Merged

Provide MDT Dynamic Inventory script #18352

merged 4 commits into from Nov 7, 2016

Conversation

jbarnett1981
Copy link
Contributor

@jbarnett1981 jbarnett1981 commented Nov 3, 2016 •
edited

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
ANSIBLE VERSION
ansible 2.1.1.0
  config file = /Users/jbarnett/Documents/python/ansible-playbooks/ansible.cfg
  configured module search path = Default w/o overrides
SUMMARY

Provide a dynamic inventory script to query MDT (Windows)

@jbarnett1981 jbarnett1981 changed the title Add files via upload Provide MDT Dynamic Inventory script Nov 3, 2016
@abadger abadger added feature_pull_request affects_2.3 This issue/PR affects Ansible v2.3 labels Nov 3, 2016
@jbarnett1981
Update mdt_dynamic_inventory.py
cd1209a 
Adding maintainer name in docstring
fixing deprecated print syntax on a few lines
fixing configparser import to support python2 and python3
@jbarnett1981
Update mdt_dynamic_inventory.py
7011659
@jhawkesworth jhawkesworth added the windows Windows community label Nov 4, 2016
@jhawkesworth
Copy link
Contributor

MDT = microsoft deployment toolkit so labelling this as a windows thing.

@abadger
Copy link
Contributor

abadger commented Nov 4, 2016

Talked with other committers and it looks like the core requirements for a dynamic inventory script that we accept into ansible are that it implements both --list and --host. It looks like this one only implements --list right now. If you implement --host as well then we can look at merging this. Thanks!

needs_revision

@abadger abadger added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Nov 4, 2016
@jbarnett1981
Update mdt_dynamic_inventory.py
fae42ba 
Adding --host functionality
@abadger abadger merged commit 2f7983e into ansible:devel Nov 7, 2016
@abadger abadger removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Nov 7, 2016
@jbarnett1981 jbarnett1981 added this to the 2.3.0 milestone Nov 7, 2016
@abadger
Copy link
Contributor

abadger commented Nov 7, 2016

Merged to devel. Thanks @jbarnett1981 !

@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 4, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.3 This issue/PR affects Ansible v2.3 feature This issue/PR relates to a feature request. windows Windows community
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jbarnett1981 @jhawkesworth @abadger @ansibot