setup defines ansible_selinux as a boolean or as a dict

[dagwieers]

ISSUE TYPE

• Bug Report

COMPONENT NAME

setup / facts

ANSIBLE VERSION

v2.2 and older

SUMMARY

Looking at the code https://github.com/ansible/ansible/blob/devel/lib/ansible/module_utils/facts.py#L420 it defines ansible_selinux either as a boolean (False) when HAVE_SELINUX is False, but as a dictionary when HAVE_SELINUX is True.

That is bad design, it makes it harder to test for specific properties.
https://github.com/ansible/ansible/pull/18690/files#diff-6ef0fa8be07ffd2967bf772e9d792339R20

when: ansible_selinux is defined and ansible_selinux.status == 'enabled'

fails if it is a boolean, so I now have to rewrite this as:

when: ansible_selinux is defined and ansible_selinux != False and ansible_selinux.status == 'enabled'

and I won't be certain that this will not fail in some weird way (like maybe on some platform it returns True instead of a dictionary with status key).

[ansibot]

@dagwieers: Thanks for taking the time to open this issue, but it was filed under the wrong github repository. Please create a new issue at https://github.com/ansible/ansible-modules-core/issues
click here for bot help

[dagwieers]

@ansibot You are quite wrong, this is part of ansible/ansible. Oh, why am I talking to a bot :-)

EDIT: remove broken command -jctanner

[sivel]

bot_skip

[sivel]

Some of this was discussed in short in a core meeting, although from a slightly different topic.

Ref: https://meetbot-raw.fedoraproject.org/ansible-meeting/2016-09-01/public_core_meeting.2016-09-01-15.09.log.html

[dagwieers]

@sivel Thanks for the pointer !

However what was concluded does not seem to be implemented. (I haven't seen the output in the Shippable console). Is this somewhere on a TODO list ? Something I could be working on maybe ?

[abadger]

@Trozz was there any new information on #16612 ? This ticket is diving into similar areas.

[samdoran]

Fixed in #31065.

Cherry-picked for inclusion in 2.4.1.