Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded quotes - windows/win_unzip.py #18827

Merged
merged 1 commit into from Dec 15, 2016
Merged

Remove unneeded quotes - windows/win_unzip.py #18827

merged 1 commit into from Dec 15, 2016

Conversation

Fale
Copy link
Contributor

@Fale Fale commented Dec 7, 2016

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

windows/win_unzip.py

ANSIBLE VERSION
2.2
SUMMARY

Remove unneeded quotes.

@gundalow

@Fale Fale mentioned this pull request Dec 9, 2016
Closed
gundalow
gundalow reviewed Dec 9, 2016
View reviewed changes
Copy link
Contributor

@gundalow gundalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though needs an extra set of eyes before merging.

@ansibot ansibot added affects_2.3 This issue/PR affects Ansible v2.3 docs_pull_request module This issue/PR relates to a module. windows Windows community labels Dec 13, 2016
@jborean93
Copy link
Contributor

I believe you need to double the \ when using string in the py file. It will only come up as 1 \ when viewing it in the webdocs format but you will have to double check that.

@nitzmahone
Copy link
Member

@jborean93 The thing that makes it work is that the herestring is raw (prefaced with r) to turn off all Python escaping - that's the way we should be doing any docs with naked Windows paths going forward.

@nitzmahone nitzmahone merged commit cf5449c into ansible:devel Dec 15, 2016
@Fale Fale deleted the windows/win_unzip.py branch December 15, 2016 18:49
@ansibot ansibot added docs This issue/PR relates to or includes documentation. and removed docs_pull_request labels Mar 3, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow left review comments

Assignees

@nitzmahone nitzmahone

Labels
affects_2.3 This issue/PR affects Ansible v2.3 docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Fale @jborean93 @nitzmahone @gundalow @ansibot