New module - iam_role #19486
Merged
New module - iam_role #19486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Migrated from ansible/ansible-modules-extras#2201 |
ansibot
added
affects_2.3
gundalow
requested changes
Dec 19, 2016
| short_description: Manage AWS IAM roles | ||
| description: | ||
| - Manage AWS IAM roles | ||
| version_added: "2.2" |
| else: | ||
| destroy_role(connection, module) | ||
|
|
||
| from ansible.module_utils.basic import * |
There was a problem hiding this comment.
Please import only what you need, rather than *.
There was a problem hiding this comment.
Is this a new requirement? I've always written my modules like this. Is there doc for likely necessary includes?
There was a problem hiding this comment.
ansibot
added
needs_triage
gundalow
removed
the
needs_triage
|
Given the reviews in ansible/ansible-modules-extras#2201 once my comments have been addressed I think we can merge this |
ansibot
added
needs_revision
|
@wimnat The file |
wimnat
force-pushed
the
ansible-modules-extras/pull/2201
branch
from
5b78095
to
4ad781d
Compare
ansibot
removed
the
needs_revision
gundalow
approved these changes
Dec 22, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
COMPONENT NAME
iam_role
ANSIBLE VERSION
2.2
SUMMARY
Module to allow managing AWS IAM roles. Similar functionality to current iam module but it was decided that the module should be split in to separate ones i.e. iam_role, iam_user, iam_group.
This module is the first of that split.
Extra functionality includes support for managed policies