Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lineinfile: add regex as an alias for regexp #20454

Merged
merged 1 commit into from
Jun 20, 2018
Merged

lineinfile: add regex as an alias for regexp #20454

merged 1 commit into from
Jun 20, 2018

Conversation

evgeni
Copy link
Contributor

@evgeni evgeni commented Jan 19, 2017

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

lib/ansible/modules/files/lineinfile.py

ANSIBLE VERSION
ansible 2.3.0 (lininfile-regex-alias 442071ae46) last updated 2017/01/19 14:39:11 (GMT +200)
  config file = /etc/ansible/ansible.cfg
  configured module search path = Default w/o overrides
SUMMARY

the param is called regexp, but a lot of people spell it regex add an alias to help them

@ansibot ansibot added affects_2.3 This issue/PR affects Ansible v2.3 core_review In order to be merged, this PR must follow the core review workflow. feature_pull_request module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jan 19, 2017
@nitzmahone nitzmahone removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. labels Jan 20, 2017
@ansibot ansibot added the core_review In order to be merged, this PR must follow the core review workflow. label Jan 20, 2017
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 11, 2017
@ansibot ansibot added the support:core This issue/PR relates to code supported by the Ansible Engineering Team. label Jun 29, 2017
@ansibot
Copy link
Contributor

ansibot commented Jul 19, 2017

cc @ahtik @dhozac
click here for bot help

@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Nov 5, 2017
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 2, 2018
@ansibot
Copy link
Contributor

ansibot commented May 29, 2018

cc @samdoran
click here for bot help

@evgeni @samdoran
lineinfile: add regex as an alias for regexp
a4af08c 
the param is called regexp, but a lot of people spell it regex
add an alias to help them
@samdoran samdoran self-assigned this Jun 19, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 19, 2018
@samdoran samdoran merged commit e601caf into ansible:devel Jun 20, 2018
jacum pushed a commit to jacum/ansible that referenced this pull request Jun 26, 2018
@evgeni
lineinfile: add regex as an alias for regexp (ansible#20454)
0bea0c3 
the param is called regexp, but a lot of people spell it regex
add an alias to help them
@ansible ansible locked and limited conversation to collaborators Jun 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@samdoran samdoran

Labels
affects_2.3 This issue/PR affects Ansible v2.3 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@evgeni @ansibot @samdoran @nitzmahone