Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default voice of Alex seems safer #20718

Merged
merged 1 commit into from
Jan 28, 2017
Merged

default voice of Alex seems safer #20718

merged 1 commit into from
Jan 28, 2017

Conversation

isopy
Copy link
Contributor

@isopy isopy commented Jan 26, 2017

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ansible/modules/notification/osx_say.py

ANSIBLE VERSION
ansible 2.2.0.0
  config file =
  configured module search path = Default w/o overrides
SUMMARY

The voice paramater is not required and the current default fails on macOS Sierra. Alex is a safer default as it's persisted across versions up to this point.

**Playbook:**
# talk.yml
--- 
- hosts: localhost
  connection: local

  tasks:
    - name: osx say something
      osx_say:
        msg: '{{ inventory_hostname }} is talking'

**BEFORE the fix:**
$ ansible-playbook talk.yml

PLAY [localhost] ***************************************************************

TASK [setup] *******************************************************************
ok: [localhost]

TASK [osx say something] *******************************************************
fatal: [localhost]: FAILED! => {"changed": false, "cmd": "/usr/bin/say 'localhost is talking again' --voice=Trinoids", "failed": true, "msg": "Voice `Trinoids' not found.", "rc": 1, "stderr": "Voice `Trinoids' not found.\n", "stdout": "", "stdout_lines": []}

PLAY RECAP *********************************************************************
localhost

**AFTER the fix:**
$ ansible-playbook talk.yml

PLAY [localhost] ***************************************************************

TASK [setup] *******************************************************************
ok: [localhost]

TASK [osx say something] *******************************************************
ok: [localhost]

PLAY RECAP *********************************************************************
localhost                  : ok=2    changed=0    unreachable=0    failed=0

@ansibot ansibot added affects_2.3 This issue/PR affects Ansible v2.3 bugfix_pull_request community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. labels Jan 26, 2017
@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Jan 27, 2017
@resmo resmo merged commit c29d1e3 into ansible:devel Jan 28, 2017
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 5, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.3 This issue/PR affects Ansible v2.3 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants