Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor E-Series Storage-Pool to use module_utils #20900

Merged
merged 1 commit into from
Sep 12, 2017
Merged

Refactor E-Series Storage-Pool to use module_utils #20900

merged 1 commit into from
Sep 12, 2017

Conversation

lmprice
Copy link
Contributor

@lmprice lmprice commented Jan 31, 2017

Refactor the NetApp E-Series module to utilize the common module_utils
and doc_fragments.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

netapp_e_storagepool

ANSIBLE VERSION
ansible 2.3.0
  config file = /home/lorenp/ansible/lib/ansible.cfg
  configured module search path = Default w/o overrides
SUMMARY

This patch is intended to bring the NetApp E-Series modules more in line with the other NetApp modules and with the updated best practices by utilizing doc_fragments and module_utils for common code. This patch is not intended to change any existing functionality or output.

This patch is a simplification of my original PR (#20764); I was asked to split it into one PR per module.

@ansibot
Copy link
Contributor

ansibot commented Jan 31, 2017

cc @hulquest
click here for bot help

@ansibot ansibot added affects_2.3 This issue/PR affects Ansible v2.3 bugfix_pull_request c:module_utils/ community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Jan 31, 2017
@hulquest
Copy link
Contributor

hulquest commented Feb 1, 2017

Thank you for the contribution. LGTM
shipit

@ansibot
Copy link
Contributor

ansibot commented Feb 1, 2017

@hulquest

The netapp_e_storagepool module has only one maintainer and this request needs 2 shipits. As a maintainer of a module in the same namespace, you can add a shipit to help move this request along.

click here for bot help

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. labels Feb 1, 2017
@hulquest
Copy link
Contributor

hulquest commented Feb 1, 2017

Adding a second shipit to move the process along.

@ansibot
Copy link
Contributor

ansibot commented Feb 10, 2017

cc @timuster
click here for bot help

@ansibot ansibot added owner_pr This PR is made by the module's maintainer. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Feb 10, 2017
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 11, 2017
@ansibot ansibot added the support:community This issue/PR relates to code supported by the Ansible community. label Jun 29, 2017
@calfonso calfonso added the needs_info This issue requires further information. Please answer any outstanding questions. label Jul 5, 2017
@ansibot ansibot added the shipit This PR is ready to be merged by Core label Jul 19, 2017
@lmprice
Refactor E-Series Storage-Pool to use module_utils
8b88341 
Refactor the NetApp E-Series module to utlize the common module_utils
and doc_fragments.
@ansibot ansibot removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. shipit This PR is ready to be merged by Core stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Aug 8, 2017
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 16, 2017
@ansibot
Copy link
Contributor

ansibot commented Aug 24, 2017

cc @broncofan
click here for bot help

@lmprice
Copy link
Contributor Author

lmprice commented Sep 12, 2017

@broncofan Can you give me a shipit here?

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_info This issue requires further information. Please answer any outstanding questions. labels Sep 12, 2017
@broncofan
Copy link

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core automerge This PR was automatically merged by ansibot. and removed community_review In order to be merged, this PR must follow the community review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Sep 12, 2017
@ansibot ansibot merged commit fd8b1e5 into ansible:devel Sep 12, 2017
prasadkatti pushed a commit to prasadkatti/ansible that referenced this pull request Oct 1, 2017
@lmprice
Refactor E-Series Storage-Pool to use module_utils (ansible#20900)
d39a671 
Refactor the NetApp E-Series module to utlize the common module_utils
and doc_fragments.
BondAnthony pushed a commit to BondAnthony/ansible that referenced this pull request Oct 5, 2017
@lmprice @BondAnthony
Refactor E-Series Storage-Pool to use module_utils (ansible#20900)
3c67e1a 
Refactor the NetApp E-Series module to utlize the common module_utils
and doc_fragments.
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 5, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.3 This issue/PR affects Ansible v2.3 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. c:module_utils/ module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lmprice @ansibot @hulquest @broncofan @calfonso