Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default value for remote_src #21136

Merged
merged 1 commit into from
Feb 9, 2017

Conversation

t-my
Copy link

@t-my t-my commented Feb 8, 2017

Default value is clearly False, fixed it to correct value.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

copy module

ANSIBLE VERSION
2.2.0.0
SUMMARY

Fixed default value to False, which is stated in description.


Default value is clearly False, fixed it to correct value.
@ansibot ansibot added affects_2.3 This issue/PR affects Ansible v2.3 core_review In order to be merged, this PR must follow the core review workflow. docs_pull_request module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. labels Feb 8, 2017
@abadger abadger removed the needs_triage Needs a first human triage before being processed. label Feb 9, 2017
@abadger
Copy link
Contributor

abadger commented Feb 9, 2017

no and False are equivalent yaml values so they should both work. Not sure about the choices for true and false being in the documentation, Leaving it up to @dharmabumstead about what we should normalize these on (no choices argument for boolean values and no/yes true/false are both okay depending on context perhaps?)

@dharmabumstead
Copy link
Contributor

I'd say for doc purposes usually true/false but it can depend on the context.

@dharmabumstead dharmabumstead merged commit 829f3bd into ansible:devel Feb 9, 2017
@dharmabumstead
Copy link
Contributor

Thanks @tsoikkel and @abadger!

@ansibot ansibot added docs This issue/PR relates to or includes documentation. and removed docs_pull_request labels Mar 4, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.3 This issue/PR affects Ansible v2.3 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants