Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates eos modules to use socket #21197

Merged
merged 1 commit into from
Feb 14, 2017
Merged

updates eos modules to use socket #21197

merged 1 commit into from
Feb 14, 2017

Conversation

privateip
Copy link
Contributor

  • updates eos modules to use persistent connection socket
  • removes split eos shared module and combines into one
  • adds singular eos doc frag (eos_local to be removed after module updates)

@ansibot
Copy link
Contributor

ansibot commented Feb 9, 2017

cc @gundalow @Qalthos
click here for bot help

@ansibot ansibot added affects_2.3 This issue/PR affects Ansible v2.3 c:module_utils/ core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category owner_pr This PR is made by the module's maintainer. labels Feb 9, 2017
@ansibot ansibot assigned gundalow and Qalthos and unassigned gundalow Feb 9, 2017
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Feb 9, 2017
@mattclay
Copy link
Member

mattclay commented Feb 9, 2017

CI failure due to unit test errors such as this:

2017-02-09 14:41:27 Traceback:
2017-02-09 14:41:27 test/units/modules/network/eos/test_eos_system.py:32: in <module>
2017-02-09 14:41:27     from ansible.modules.network.eos import eos_system
2017-02-09 14:41:27 lib/ansible/modules/network/eos/eos_system.py:160: in <module>
2017-02-09 14:41:27     from ansible.module_utils.eos import load_config, get_config
2017-02-09 14:41:27 lib/ansible/module_utils/eos.py:39: in <module>
2017-02-09 14:41:27     from ansible.module_utils.network_common import exec_command
2017-02-09 14:41:27 E   ImportError: cannot import name exec_command
2017-02-09 14:41:27 _______ ERROR collecting test/units/modules/network/eos/test_eos_user.py _______

@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Feb 9, 2017
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Feb 9, 2017
@gundalow
Copy link
Contributor

gundalow commented Feb 9, 2017 

2017-02-09 14:41:27 ==================================== ERRORS ====================================
2017-02-09 14:41:27 _____________ ERROR collecting test/units/module_utils/test_eos.py _____________
2017-02-09 14:41:27 ImportError while importing test module '/root/src/github.com/ansible/ansible/test/units/module_utils/test_eos.py'.
2017-02-09 14:41:27 Hint: make sure your test modules/packages have valid Python names.
2017-02-09 14:41:27 Traceback:
2017-02-09 14:41:27 test/units/module_utils/test_eos.py:29: in <module>
2017-02-09 14:41:27     from ansible.module_utils import eos
2017-02-09 14:41:27 lib/ansible/module_utils/eos.py:39: in <module>
2017-02-09 14:41:27     from ansible.module_utils.network_common import exec_command
2017-02-09 14:41:27 E   ImportError: cannot import name exec_command
2017-02-09 14:41:27 ______ ERROR collecting test/units/modules/network/eos/test_eos_banner.py ______
2017-02-09 14:41:27 ImportError while importing test module '/root/src/github.com/ansible/ansible/test/units/modules/network/eos/test_eos_banner.py'.
2017-02-09 14:41:27 Hint: make sure your test modules/packages have valid Python names.
2017-02-09 14:41:27 Traceback:
2017-02-09 14:41:27 test/units/modules/network/eos/test_eos_banner.py:26: in <module>
2017-02-09 14:41:27     from ansible.modules.network.eos import eos_banner
2017-02-09 14:41:27 lib/ansible/modules/network/eos/eos_banner.py:111: in <module>
2017-02-09 14:41:27     from ansible.module_utils.eos import load_config, run_commands
2017-02-09 14:41:27 lib/ansible/module_utils/eos.py:39: in <module>
2017-02-09 14:41:27     from ansible.module_utils.network_common import exec_command
2017-02-09 14:41:27 E   ImportError: cannot import name exec_command
2017-02-09 14:41:27 _____ ERROR collecting test/units/modules/network/eos/test_eos_command.py ______
2017-02-09 14:41:27 ImportError while importing test module '/root/src/github.com/ansible/ansible/test/units/modules/network/eos/test_eos_command.py'.
2017-02-09 14:41:27 Hint: make sure your test modules/packages have valid Python names.
2017-02-09 14:41:27 Traceback:
2017-02-09 14:41:27 test/units/modules/network/eos/test_eos_command.py:28: in <module>
2017-02-09 14:41:27     from ansible.modules.network.eos import eos_command
2017-02-09 14:41:27 lib/ansible/modules/network/eos/eos_command.py:134: in <module>
2017-02-09 14:41:27     from ansible.module_utils.eos import run_commands, eos_argument_spec
2017-02-09 14:41:27 lib/ansible/module_utils/eos.py:39: in <module>
2017-02-09 14:41:27     from ansible.module_utils.network_common import exec_command
2017-02-09 14:41:27 E   ImportError: cannot import name exec_command
2017-02-09 14:41:27 ______ ERROR collecting test/units/modules/network/eos/test_eos_config.py ______
2017-02-09 14:41:27 ImportError while importing test module '/root/src/github.com/ansible/ansible/test/units/modules/network/eos/test_eos_config.py'.
2017-02-09 14:41:27 Hint: make sure your test modules/packages have valid Python names.
2017-02-09 14:41:27 Traceback:
2017-02-09 14:41:27 test/units/modules/network/eos/test_eos_config.py:31: in <module>
2017-02-09 14:41:27     from ansible.modules.network.eos import eos_config
2017-02-09 14:41:27 lib/ansible/modules/network/eos/eos_config.py:224: in <module>
2017-02-09 14:41:27     from ansible.module_utils import eos
2017-02-09 14:41:27 lib/ansible/module_utils/eos.py:39: in <module>
2017-02-09 14:41:27     from ansible.module_utils.network_common import exec_command
2017-02-09 14:41:27 E   ImportError: cannot import name exec_command
2017-02-09 14:41:27 _______ ERROR collecting test/units/modules/network/eos/test_eos_eapi.py _______
2017-02-09 14:41:27 ImportError while importing test module '/root/src/github.com/ansible/ansible/test/units/modules/network/eos/test_eos_eapi.py'.
2017-02-09 14:41:27 Hint: make sure your test modules/packages have valid Python names.
2017-02-09 14:41:27 Traceback:
2017-02-09 14:41:27 test/units/modules/network/eos/test_eos_eapi.py:32: in <module>
2017-02-09 14:41:27     from ansible.modules.network.eos import eos_eapi
2017-02-09 14:41:27 lib/ansible/modules/network/eos/eos_eapi.py:200: in <module>
2017-02-09 14:41:27     from ansible.module_utils.eos import run_commands, load_config
2017-02-09 14:41:27 lib/ansible/module_utils/eos.py:39: in <module>
2017-02-09 14:41:27     from ansible.module_utils.network_common import exec_command
2017-02-09 14:41:27 E   ImportError: cannot import name exec_command
2017-02-09 14:41:27 ______ ERROR collecting test/units/modules/network/eos/test_eos_system.py ______
2017-02-09 14:41:27 ImportError while importing test module '/root/src/github.com/ansible/ansible/test/units/modules/network/eos/test_eos_system.py'.
2017-02-09 14:41:27 Hint: make sure your test modules/packages have valid Python names.
2017-02-09 14:41:27 Traceback:
2017-02-09 14:41:27 test/units/modules/network/eos/test_eos_system.py:32: in <module>
2017-02-09 14:41:27     from ansible.modules.network.eos import eos_system
2017-02-09 14:41:27 lib/ansible/modules/network/eos/eos_system.py:160: in <module>
2017-02-09 14:41:27     from ansible.module_utils.eos import load_config, get_config
2017-02-09 14:41:27 lib/ansible/module_utils/eos.py:39: in <module>
2017-02-09 14:41:27     from ansible.module_utils.network_common import exec_command
2017-02-09 14:41:27 E   ImportError: cannot import name exec_command
2017-02-09 14:41:27 _______ ERROR collecting test/units/modules/network/eos/test_eos_user.py _______
2017-02-09 14:41:27 ImportError while importing test module '/root/src/github.com/ansible/ansible/test/units/modules/network/eos/test_eos_user.py'.
2017-02-09 14:41:27 Hint: make sure your test modules/packages have valid Python names.
2017-02-09 14:41:27 Traceback:
2017-02-09 14:41:27 test/units/modules/network/eos/test_eos_user.py:26: in <module>
2017-02-09 14:41:27     from ansible.modules.network.eos import eos_user
2017-02-09 14:41:27 lib/ansible/modules/network/eos/eos_user.py:166: in <module>
2017-02-09 14:41:27     from ansible.module_utils.eos import get_config, load_config
2017-02-09 14:41:27 lib/ansible/module_utils/eos.py:39: in <module>
2017-02-09 14:41:27     from ansible.module_utils.network_common import exec_command
2017-02-09 14:41:27 E   ImportError: cannot import name exec_command
2017-02-09 14:41:27 !!!!!!!!!!!!!!!!!!! Interrupted: 7 errors during collection !!!!!!!!!!!!!!!!!!!!
2017-02-09 14:41:27 ====================== 2 skipped, 7 error in 2.85 seconds ======================

@ansibot ansibot added c:plugins/action and removed ci_verified Changes made in this PR are causing tests to fail. labels Feb 10, 2017
@mattclay
Copy link
Member

CI failure due to unit test errors:

2017-02-10 01:10:02 ==================================== ERRORS ====================================
2017-02-10 01:10:02 ______ ERROR collecting test/units/modules/network/eos/test_eos_config.py ______
2017-02-10 01:10:02 ImportError while importing test module '/root/src/github.com/ansible/ansible/test/units/modules/network/eos/test_eos_config.py'.
2017-02-10 01:10:02 Hint: make sure your test modules/packages have valid Python names.
2017-02-10 01:10:02 Traceback:
2017-02-10 01:10:02 test/units/modules/network/eos/test_eos_config.py:31: in <module>
2017-02-10 01:10:02     from ansible.modules.network.eos import eos_config
2017-02-10 01:10:02 lib/ansible/modules/network/eos/eos_config.py:210: in <module>
2017-02-10 01:10:02     from ansible.module_utils.eos import supports_sessions, run_commands
2017-02-10 01:10:02 E   ImportError: cannot import name supports_sessions
2017-02-10 01:10:02 !!!!!!!!!!!!!!!!!!! Interrupted: 1 errors during collection !!!!!!!!!!!!!!!!!!!!

@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Feb 10, 2017
@ansibot ansibot added test_pull_requests and removed ci_verified Changes made in this PR are causing tests to fail. labels Feb 10, 2017
@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Feb 10, 2017
@mattclay
Copy link
Member

CI failure due to import failure in unit tests:

2017-02-10 15:07:22 ==================================== ERRORS ====================================
2017-02-10 15:07:22 ______ ERROR collecting test/units/modules/network/eos/test_eos_config.py ______
2017-02-10 15:07:22 ImportError while importing test module '/root/src/github.com/ansible/ansible/test/units/modules/network/eos/test_eos_config.py'.
2017-02-10 15:07:22 Hint: make sure your test modules/packages have valid Python names.
2017-02-10 15:07:22 Traceback:
2017-02-10 15:07:22 test/units/modules/network/eos/test_eos_config.py:27: in <module>
2017-02-10 15:07:22     from ansible.modules.network.eos import eos_config
2017-02-10 15:07:22 lib/ansible/modules/network/eos/eos_config.py:210: in <module>
2017-02-10 15:07:22     from ansible.module_utils.eos import supports_sessions, run_commands
2017-02-10 15:07:22 E   ImportError: cannot import name supports_sessions

@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Feb 10, 2017
@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Feb 11, 2017
@gundalow
Copy link
Contributor

Same comments as on #21231

@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Feb 12, 2017
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. community_review In order to be merged, this PR must follow the community review workflow. labels Feb 12, 2017
updates eos modules to use socket
03f61b6 
* updates eos modules to use persistent connection socket
* removes split eos shared module and combines into one
* adds singular eos doc frag (eos_local to be removed after module updates)
* updates unit test cases
@ansibot ansibot added c:plugins/terminal needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. community_review In order to be merged, this PR must follow the community review workflow. and removed community_review In order to be merged, this PR must follow the community review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 13, 2017
@privateip privateip merged commit 14b942f into ansible:devel Feb 14, 2017
@privateip privateip deleted the eos-updates branch February 14, 2017 01:22
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.3 This issue/PR affects Ansible v2.3 c:module_utils/ c:plugins/action c:plugins/terminal community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. networking Network category owner_pr This PR is made by the module's maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@privateip @ansibot @mattclay @gundalow @Qalthos