Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aos_ip_pool - Clean up doc #21265

Merged
merged 1 commit into from
Feb 10, 2017
Merged

aos_ip_pool - Clean up doc #21265

merged 1 commit into from
Feb 10, 2017

Conversation

dgarros
Copy link
Contributor

@dgarros dgarros commented Feb 10, 2017

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

network/aos/aos_ip_pool

ANSIBLE VERSION
ansible 2.3.0 (fix_ip_pool_doc bcf9c00ecb) last updated 2017/02/10 11:35:25 (GMT -700)
  config file =
  configured module search path = Default w/o overrides
SUMMARY

Small cleanup of the documentation to incorporate feedback from the other modules from @gundalow

  • Removed required: false
  • Add hard stop

@ansibot
Copy link
Contributor

ansibot commented Feb 10, 2017

cc @jeremyschulman
click here for bot help

@ansibot ansibot added affects_2.3 This issue/PR affects Ansible v2.3 bugfix_pull_request community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. networking Network category owner_pr This PR is made by the module's maintainer. labels Feb 10, 2017
@gundalow gundalow merged commit 2f69669 into ansible:devel Feb 10, 2017
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 5, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow approved these changes

Assignees
No one assigned
Labels
affects_2.3 This issue/PR affects Ansible v2.3 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. networking Network category owner_pr This PR is made by the module's maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dgarros @ansibot @gundalow