win_uri: Replace -type "string" with -type "str" #21373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Type "string" does not exist.
ansibot
added
affects_2.3
bcoca
removed
the
needs_triage
|
Ah.. just seen you've gone from 'string' to 'str' on this one (see my comments on #21377 ) so clearly you have a reason in mind for this change. |
|
@jhawkesworth It is not a change from "string" to "str", but rather a change from nothing to "str". There was nothing implemented before I implemented it in powershell.ps1 And the reason for me to use "str" rather than "string" is because it is consistent with what already exists in Ansible. See #21377 too :-) |
|
ready_for_review |
nitzmahone
approved these changes
Feb 24, 2017
ansibot
added
bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
COMPONENT NAME
win_uri
ANSIBLE VERSION
v2.3
SUMMARY
Type "string" does not exist.