Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor yum module: remove irelevant if conditionals for disable/enablerepo #21619

Closed
vmindru opened this issue Feb 18, 2017 · 4 comments
Closed

refactor yum module: remove irelevant if conditionals for disable/enablerepo #21619

vmindru opened this issue Feb 18, 2017 · 4 comments
Assignees
@vmindru
Labels
affects_2.3 This issue/PR affects Ansible v2.3 bug This issue/PR relates to a bug. module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team.

Comments

@vmindru
Copy link
Contributor

vmindru commented Feb 18, 2017

ISSUE TYPE
  • Bug Report
COMPONENT NAME

yum.py

ANSIBLE VERSION

2.3

This has been triggered by: #19587 and #195870, within this PR this has been documented
right in the yum.py.
@vmindru vmindru mentioned this issue Feb 18, 2017
Merged
@ansibot ansibot added affects_2.3 This issue/PR affects Ansible v2.3 bug_report module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. labels Feb 18, 2017
@alikins alikins removed the needs_triage Needs a first human triage before being processed. label Feb 20, 2017
@ansibot ansibot added the support:core This issue/PR relates to code supported by the Ansible Engineering Team. label Jun 29, 2017
@ansibot
Copy link
Contributor

ansibot commented Jul 19, 2017

cc @berenddeschouwer @verm666
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Sep 26, 2017

cc @mkrizek
click here for bot help

@vmindru
Copy link
Contributor Author

vmindru commented Sep 26, 2017

@mkrizek man i think this one has to be closed.

  1. i really don't have time to care of this in near couple of weeks
  2. that yum module needs a lot of attention and fixes as there are "workarounds" other "workarounds"
    my last attempt to pull a bigger fix was not welcomed with a good reason, the team prefers small incremental changes rather than one big one.
  3. Chalanges to keep it compatible with old yum versions, python versions and OS makes this even more fun :)

If you still think you want this open and taken care off, m might help if we would agree on some tackle plan.

P.S. Say hi to Brno folks .

@mkrizek
Copy link
Contributor

mkrizek commented Oct 3, 2017

@vmindru agreed, my plan is to refactor the code along with the new bugfixes and more integration tests coverage.

@mkrizek mkrizek closed this as completed Oct 3, 2017
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bug_report labels Mar 7, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@vmindru vmindru

Labels
affects_2.3 This issue/PR affects Ansible v2.3 bug This issue/PR relates to a bug. module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alikins @mkrizek @ansibot @vmindru