Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory ios facts #21696

Merged
merged 1 commit into from
Feb 21, 2017
Merged

Fix memory ios facts #21696

merged 1 commit into from
Feb 21, 2017

Conversation

rcarrillocruz
Copy link
Contributor

In order to populate the total and free mem of an IOS device, we run
the 'show memory statistics' command.
The output shows something similar to:

            Head    Total(b)     Used(b)     Free(b)   Lowest(b)  Largest(b)

Processor BEAE880 335215488 64044364 271171124 268918092 268463852
I/O 8DAE880 51380224 41880736 9499488 9461552 9352252

We need to just parse the line containing 'Processor' and get the first and third
number for total and free mem, instaed for first and second as the code wrongly
does.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ios_facts

ANSIBLE VERSION
ansible 2.3.0 (fix_show_mem_ios_facts 923df91fb5) last updated 2017/02/21 00:52:38 (GMT +200)

@rcarrillocruz
Fix memory ios facts
923df91 
In order to populate the total and free mem of an IOS device, we run
the 'show memory statistics' command.
The output shows something similar to:

                Head    Total(b)     Used(b)     Free(b)   Lowest(b)  Largest(b)
Processor    BEAE880   335215488    64044364   271171124   268918092   268463852
      I/O    8DAE880    51380224    41880736     9499488     9461552     9352252

We need to just parse the line containing 'Processor' and get the first and third
number for total and free mem, instaed for first and second as the code wrongly
does.
@ansibot
Copy link
Contributor

ansibot commented Feb 21, 2017

cc @privateip @gundalow @Qalthos
click here for bot help

@ansibot ansibot added affects_2.3 This issue/PR affects Ansible v2.3 bugfix_pull_request core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category owner_pr This PR is made by the module's maintainer. labels Feb 21, 2017
@ansibot ansibot assigned privateip, gundalow and Qalthos and unassigned privateip and gundalow Feb 21, 2017
privateip
privateip approved these changes Feb 21, 2017
View reviewed changes
Copy link
Contributor

@privateip privateip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Feb 21, 2017
@rcarrillocruz rcarrillocruz merged commit 6622b05 into ansible:devel Feb 21, 2017
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 5, 2018
@dagwieers dagwieers added ios Cisco IOS community cisco Cisco technologies labels Feb 27, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@privateip privateip privateip approved these changes

Assignees

@Qalthos Qalthos

Labels
affects_2.3 This issue/PR affects Ansible v2.3 bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. ios Cisco IOS community module This issue/PR relates to a module. networking Network category owner_pr This PR is made by the module's maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rcarrillocruz @ansibot @privateip @dagwieers @Qalthos @gundalow