Autoscaling Groups Lifecycle Hooks module #22412

tsiganenok · 2017-03-08T15:09:33Z

SUMMARY

New module which allows managing ASG Lifecycle hooks.

ISSUE TYPE

New Module Pull Request

COMPONENT NAME

ec2_asg_lifecycle_hook

ANSIBLE VERSION

[root@localhost playbooks]# ansible --version
ansible 2.2.1.0
config file = /etc/ansible/ansible.cfg
configured module search path = Default w/o overrides

ADDITIONAL INFORMATION

There is no module allowing Lifecycle Hooks management for AWS Autoscaling Groups for now.
More about Lifecycle Hooks: http://docs.aws.amazon.com/autoscaling/latest/userguide/lifecycle-hooks.html
It uses boto3 and there is no separate documentation for hooks, but only in autoscaling section:
http://boto3.readthedocs.io/en/latest/reference/services/autoscaling.html

ansibot · 2017-03-08T15:16:22Z

cc @willthames
click here for bot help

ansibot · 2017-03-08T20:20:31Z

The test ansible-test compile --python 2.6 failed with the following error:

lib/ansible/modules/cloud/amazon/ec2_asg_lifecycle_hook.py:176:38: SyntaxError: modified = {o : (d1[o], d2[o]) for o in intersect_keys if d1[o] != d2[o]}

click here for bot help

ansibot · 2017-03-10T20:20:41Z

The test ansible-test compile --python 2.6 failed with the following error:

lib/ansible/modules/cloud/amazon/ec2_asg_lifecycle_hook.py:176:38: SyntaxError: modified = {o : (d1[o], d2[o]) for o in intersect_keys if d1[o] != d2[o]}

The test ansible-test sanity --test ansible-doc --python 2.6 failed with the following error:

Command "ansible-doc ec2_asg_lifecycle_hook" returned exit status 1.
>>> Standard Error
[ERROR]: unable to parse /root/src/github.com/ansible/ansible/lib/ansible/modu
les/cloud/amazon/ec2_asg_lifecycle_hook.py
ERROR! module ec2_asg_lifecycle_hook missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test validate-modules failed with the following errors:

lib/ansible/modules/cloud/amazon/ec2_asg_lifecycle_hook.py:0:0: E303 DOCUMENTATION fragment missing: ['aws', 'ec2', 'asg']
lib/ansible/modules/cloud/amazon/ec2_asg_lifecycle_hook.py:0:0: E307 version_added should be 2.3. Currently 1.6
lib/ansible/modules/cloud/amazon/ec2_asg_lifecycle_hook.py:0:0: E312 No RETURN documentation provided
lib/ansible/modules/cloud/amazon/ec2_asg_lifecycle_hook.py:0:0: E208 module_utils imports should import specific components, not "*". line 101
lib/ansible/modules/cloud/amazon/ec2_asg_lifecycle_hook.py:0:0: E208 module_utils imports should import specific components, not "*". line 102

click here for bot help

mattclay · 2017-03-10T20:23:44Z

@tsiganenok I restarted CI for this PR since the bot didn't pick up all the errors the first time.

willthames · 2017-03-13T05:29:06Z

lib/ansible/modules/cloud/amazon/ec2_asg_lifecycle_hook.py

+            role_arn=dict(type='str'),
+            notification_target_arn=dict(type='str'),
+            notification_meta_data=dict(type='str'),
+            heartbeat_timeout=dict(type='str'),


If this is set to type='int' this should avoid the later type conversion

ansibot · 2017-03-14T20:40:51Z

The test ansible-test compile --python 2.6 failed with the following error:

lib/ansible/modules/cloud/amazon/ec2_asg_lifecycle_hook.py:183:38: SyntaxError: modified = {o : (d1[o], d2[o]) for o in intersect_keys if d1[o] != d2[o]}

The test ansible-test sanity --test ansible-doc --python 2.6 failed with the following error:

Command "ansible-doc ec2_asg_lifecycle_hook" returned exit status 1.
>>> Standard Error
[ERROR]: unable to parse /root/src/github.com/ansible/ansible/lib/ansible/modu
les/cloud/amazon/ec2_asg_lifecycle_hook.py
ERROR! module ec2_asg_lifecycle_hook missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test validate-modules failed with the following errors:

lib/ansible/modules/cloud/amazon/ec2_asg_lifecycle_hook.py:0:0: E208 module_utils imports should import specific components, not "*". line 108
lib/ansible/modules/cloud/amazon/ec2_asg_lifecycle_hook.py:0:0: E208 module_utils imports should import specific components, not "*". line 109
lib/ansible/modules/cloud/amazon/ec2_asg_lifecycle_hook.py:0:0: E316 ANSIBLE_METADATA.metadata_version: required key not provided @ data['metadata_version']. Got None
lib/ansible/modules/cloud/amazon/ec2_asg_lifecycle_hook.py:0:0: E316 ANSIBLE_METADATA.version: extra keys not allowed @ data['version']. Got '1.0'

click here for bot help

ansibot · 2017-03-15T19:51:03Z

@Etherdaemon @Java1Guy @akazakov @alachaum @amir343 @bekelchik @bpennypacker @brandond @fiunchinho @j-carl @jarv @jmenga @joelthompson @jsdalton @linuxdynasty @loia @MichaelBaydoun @michaeljs1990 @minichate @mjschultz @mmochan @naslanidis @pjodouin @pwnall @RickMendes @rmorlok @ryansydnor @scottanderson42 @silviud @simplesteph @steynovich @tastychutney @tedder @timmahoney @TomBamford @whiter @willthames @wimnat @Zeekin

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

yuval-almog · 2017-03-20T09:27:27Z

+1

shayisrael · 2017-03-20T09:27:38Z

+1
Will be very useful for me

classx · 2017-03-20T09:28:44Z

+1 very useful

ansibot · 2017-04-20T19:37:47Z

@tsiganenok this PR contains the following merge comits:

096e322

Please rebase your branch to remove these commits.

click here for bot help

stevenbaker · 2017-05-10T02:35:18Z

Hope this makes it into 2.4.0. Looks super useful.

s-hertel

This looks like a helpful module to have. Thanks for the time and effort you've spent on it!

s-hertel · 2017-06-15T19:15:17Z

lib/ansible/modules/cloud/amazon/ec2_asg_lifecycle_hook.py

+module: ec2_asg_lifecycle_hook
+short_description: Create, delete or update AWS ASG Lifecycle Hooks.
+description:
+  - Can create, delete or update Lifecycle Hooks for AWS Autoscaling Groups.


Can you add a more thorough description?

s-hertel · 2017-06-15T19:44:03Z

lib/ansible/modules/cloud/amazon/ec2_asg_lifecycle_hook.py

+try:
+    import boto3
+    import botocore
+    HAS_BOTO3 = True


You could import this from ansible.module_utils.ec2 instead of manually setting it here and in the except ImportError.

s-hertel · 2017-06-15T19:45:14Z

lib/ansible/modules/cloud/amazon/ec2_asg_lifecycle_hook.py

+'''
+
+RETURN = '''
+


~~Can you document what the returns look like?~~
I think this is fine since there isn't any helpful data returned by the boto3 calls. Maybe a facts module would be nice later.

So I'm leaving it as is?

s-hertel · 2017-06-15T19:47:22Z

lib/ansible/modules/cloud/amazon/ec2_asg_lifecycle_hook.py

+    if changed:
+        try:
+            connection.put_lifecycle_hook(**lch_params)
+        except Exception as e:


It would better to catch botocore.exceptions.ClientError instead of Exception.

s-hertel · 2017-06-15T20:00:54Z

lib/ansible/modules/cloud/amazon/ec2_asg_lifecycle_hook.py

+    if default_result:
+        lch_params['DefaultResult'] = default_result
+
+    existing_hook = connection.describe_lifecycle_hooks(


It would be good to have a try/except around this call.

s-hertel · 2017-06-15T20:02:03Z

lib/ansible/modules/cloud/amazon/ec2_asg_lifecycle_hook.py

+    lch_name = module.params.get('lifecycle_hook_name')
+    asg_name = module.params.get('autoscaling_group_name')
+
+    all_hooks = connection.describe_lifecycle_hooks(


It would be good to have a try/except around this call.

s-hertel · 2017-06-15T20:02:41Z

lib/ansible/modules/cloud/amazon/ec2_asg_lifecycle_hook.py

+            try:
+                connection.delete_lifecycle_hook(**lch_params)
+                changed = True
+            except Exception as e:


Catch botocore.exceptions.ClientError instead of Exception here too.

s-hertel · 2017-06-15T20:11:33Z

lib/ansible/modules/cloud/amazon/ec2_asg_lifecycle_hook.py

+        connection = boto3_conn(module, conn_type='client', resource='autoscaling', region=region, endpoint=ec2_url, **aws_connect_params)
+        if not connection:
+            module.fail_json(msg="failed to connect to AWS for the given region: %s" % str(region))
+    except boto.exception.NoAuthHandlerFound as e:


This should be botocore.exceptions.NoCredentialsError.

tsiganenok · 2017-07-27T18:46:43Z

@s-hertel Sorry for the time it took, but finally I fixed everything you asked.
What should I do about the RETURN?

tsiganenok · 2017-11-26T15:24:51Z

@ryansb Hi, is this going to be merged or do I need to fix / change anything?

tsiganenok · 2017-12-26T09:50:07Z

@s-hertel @ryansb Hi, do I need to fix / edit anything else in order to get it merged?

willthames · 2018-01-03T00:30:59Z

Merged, thanks for this @tsiganenok. This will indeed be very useful.

willthames · 2018-01-03T00:33:06Z

Didn't spot the stale_ci, oops. Should have reran the tests. I'll push a new PR shortly for the fixes.

willthames · 2018-01-03T00:44:52Z

#34379 added to fix some of the problems that would have occurred had tests been rerun.

s-hertel removed the needs_triage Needs a first human triage before being processed. label Mar 10, 2017

mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Mar 10, 2017

willthames reviewed Mar 13, 2017

View reviewed changes

ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Mar 14, 2017

mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Mar 14, 2017

ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Mar 15, 2017

ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 15, 2017

ansibot added the affects_2.4 This issue/PR affects Ansible v2.4 label Mar 20, 2017

mtpereira mentioned this pull request Apr 5, 2017

Import traceback for exception reporting. tsiganenok/ansible#1

Merged

ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 11, 2017

ansibot removed the community_review In order to be merged, this PR must follow the community review workflow. label Apr 20, 2017

ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Apr 20, 2017

pep8 fixes

62e7a65

ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 22, 2017

ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label May 10, 2017

s-hertel requested changes Jun 15, 2017

View reviewed changes

ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Jun 15, 2017

ansibot added the support:community This issue/PR relates to code supported by the Ansible community. label Jun 29, 2017

catching exception more carefuly + more detailed description

861d3d6

ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 27, 2017

ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. labels Aug 4, 2017

ryansb self-assigned this Aug 31, 2017

ansibot added the new_contributor This PR is the first contribution by a new community member. label Oct 18, 2017

ansibot removed the new_contributor This PR is the first contribution by a new community member. label Nov 3, 2017

willthames merged commit b14e5c3 into ansible:devel Jan 3, 2018

tsiganenok deleted the ec2_asg_lifecycle_hook branch January 11, 2018 23:32

ansible locked and limited conversation to collaborators Apr 26, 2019

sivel unassigned ryansb Apr 26, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Autoscaling Groups Lifecycle Hooks module #22412

Autoscaling Groups Lifecycle Hooks module #22412

tsiganenok commented Mar 8, 2017

ansibot commented Mar 8, 2017

ansibot commented Mar 8, 2017

ansibot commented Mar 10, 2017

mattclay commented Mar 10, 2017

willthames Mar 13, 2017

ansibot commented Mar 14, 2017

ansibot commented Mar 15, 2017

yuval-almog commented Mar 20, 2017

shayisrael commented Mar 20, 2017

classx commented Mar 20, 2017

ansibot commented Apr 20, 2017

stevenbaker commented May 10, 2017

s-hertel left a comment

s-hertel Jun 15, 2017

s-hertel Jun 15, 2017

s-hertel Jun 15, 2017 •

edited

tsiganenok Aug 16, 2017

s-hertel Jun 15, 2017

s-hertel Jun 15, 2017

s-hertel Jun 15, 2017

s-hertel Jun 15, 2017

s-hertel Jun 15, 2017

tsiganenok commented Jul 27, 2017

tsiganenok commented Nov 26, 2017

tsiganenok commented Dec 26, 2017

willthames commented Jan 3, 2018

willthames commented Jan 3, 2018

willthames commented Jan 3, 2018

Autoscaling Groups Lifecycle Hooks module #22412

Autoscaling Groups Lifecycle Hooks module #22412

Conversation

tsiganenok commented Mar 8, 2017

SUMMARY

ISSUE TYPE

COMPONENT NAME

ANSIBLE VERSION

ADDITIONAL INFORMATION

ansibot commented Mar 8, 2017

ansibot commented Mar 8, 2017

ansibot commented Mar 10, 2017

mattclay commented Mar 10, 2017

Choose a reason for hiding this comment

ansibot commented Mar 14, 2017

ansibot commented Mar 15, 2017

yuval-almog commented Mar 20, 2017

shayisrael commented Mar 20, 2017

classx commented Mar 20, 2017

ansibot commented Apr 20, 2017

stevenbaker commented May 10, 2017

s-hertel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

s-hertel Jun 15, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tsiganenok commented Jul 27, 2017

tsiganenok commented Nov 26, 2017

tsiganenok commented Dec 26, 2017

willthames commented Jan 3, 2018

willthames commented Jan 3, 2018

willthames commented Jan 3, 2018

s-hertel Jun 15, 2017 •

edited