Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix false positive 'changed' flag in rabbitmq_user module when using multiple permissions #22507

Merged
merged 1 commit into from
Jun 19, 2017
Merged

fix false positive 'changed' flag in rabbitmq_user module when using multiple permissions #22507

merged 1 commit into from
Jun 19, 2017

Conversation

krzysztof-magosa
Copy link
Contributor

@krzysztof-magosa krzysztof-magosa commented Mar 10, 2017 •
edited

SUMMARY

rabbitmq_user module sometimes marks task as changed even if parameters weren't really changed.
I've found that code checking permissions for changes is order-dependent.
Fix sorts lists of permissions before comparing them what fixes bug.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

rabbitmq_user

ANSIBLE VERSION
ansible 2.2.1.0
  config file = /opt/ansible/ansible.cfg
  configured module search path = Default w/o overrides

@ansibot
Copy link
Contributor

ansibot commented Mar 10, 2017

cc @manuel-sousa @chrishoffman @romanek-adam
click here for bot help

@ansibot ansibot added affects_2.3 This issue/PR affects Ansible v2.3 bugfix_pull_request community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. labels Mar 10, 2017
@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Mar 10, 2017
@romanek-adam
Copy link
Contributor

shipit

@ansibot ansibot added the affects_2.4 This issue/PR affects Ansible v2.4 label Mar 23, 2017
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 11, 2017
@krzysztof-magosa
Copy link
Contributor Author

Guys, this is trivial change, any chance to merge it?

@manuel-sousa
Copy link
Contributor

shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Jun 19, 2017
@ansibot ansibot merged commit 4522a53 into ansible:devel Jun 19, 2017
@krzysztof-magosa krzysztof-magosa deleted the rabbimtq_user-changed-permissions branch June 19, 2017 10:51
@krzysztof-magosa
Copy link
Contributor Author

Thanks.

@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 5, 2018
@groggi groggi mentioned this pull request Nov 26, 2018
Closed
@dagwieers dagwieers added the rabbitmq RabbitMQ community label Jan 28, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.3 This issue/PR affects Ansible v2.3 affects_2.4 This issue/PR affects Ansible v2.4 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. module This issue/PR relates to a module. rabbitmq RabbitMQ community shipit This PR is ready to be merged by Core stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@krzysztof-magosa @ansibot @romanek-adam @manuel-sousa @dagwieers @s-hertel