Fix incorrect command-line parameters for Solaris #22865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.4
Qalthos
removed
the
needs_triage
ansibot
added
the
stale_ci
ansibot
added
the
support:core
|
cc @jtyr would you mind reviewing this? |
jtyr
suggested changes
Aug 17, 2017
jtyr
reviewed
Aug 17, 2017
lib/ansible/modules/system/mount.py
Outdated
| @@ -327,7 +327,7 @@ def unset_mount(module, args): | |||
| def _set_fstab_args(fstab_file): | |||
| result = [] | |||
|
|
|||
| if fstab_file and fstab_file != '/etc/fstab': | |||
| if fstab_file and fstab_file != '/etc/fstab' and get_platform().lower() != 'sunos': | |||
There was a problem hiding this comment.
Please could you change it to:
if (
fstab_file and
fstab_file != '/etc/fstab' and
get_platform().lower() != 'sunos'):
There was a problem hiding this comment.
Not sure if I did it correct, but it's updated according your request.
ansibot
added
needs_revision
|
rebuild_merge |
This was referenced Aug 24, 2017
Closed
ansibot
removed
the
stale_ci
|
@jtyr Any other changes requested from you? |
|
Nop. I think if that works for you on Solaris then we can merge it now. @bcoca can you take care of it? |
bcoca
removed
the
needs_revision
prasadkatti
pushed a commit
to prasadkatti/ansible
that referenced
this pull request
Oct 1, 2017
* Fix incorrect command-line parameters for Solaris * Update mount.py
ansibot
added
bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Solaris 'mount' command does not have flag to point to fstab file.
So no such flags should be passed to the command.
Fixes #22135
ISSUE TYPE
COMPONENT NAME
mount module
ANSIBLE VERSION
ADDITIONAL INFORMATION