Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k8s/openshift module_utils split #23115

Merged
merged 1 commit into from
Mar 30, 2017
Merged

k8s/openshift module_utils split #23115

merged 1 commit into from
Mar 30, 2017

Conversation

detiber
Copy link

@detiber detiber commented Mar 30, 2017

SUMMARY

Splitting k8s_common module utils into k8s_common and openshift_common. This is to help with the decoupling that we are doing in openshift-restclient-python and will eventually allow for removing the dependency on openshift-restclient-python for the kubernetes modules.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

module_utils/k8s_common
module_utils/openshift_common

ANSIBLE VERSION

2.4

@detiber
Copy link
Author

detiber commented Mar 30, 2017

@chouseknecht ptal

@chouseknecht
Copy link
Contributor

chouseknecht commented Mar 30, 2017 •
edited

@detiber

Looks like there was a PEP8 error:

lib/ansible/module_utils/openshift_common.py:28:1: E302 expected 2 blank lines, found 1 (100%)

Other than that, this LGTM. Ping me when you get that fixed, and I'll click the merger.

@ansibot
Copy link
Contributor

ansibot commented Mar 30, 2017

The test ansible-test sanity --test pep8 failed with the following error:

lib/ansible/module_utils/openshift_common.py:28:1: E302 expected 2 blank lines, found 1

click here for bot help

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 c:module_utils/ ci_verified Changes made in this PR are causing tests to fail. feature_pull_request needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. labels Mar 30, 2017
@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 30, 2017
@detiber
Copy link
Author

detiber commented Mar 30, 2017

@chouseknecht pep8 issue corrected.

@chouseknecht chouseknecht merged commit 3642de9 into ansible:devel Mar 30, 2017
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Apr 20, 2017
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 4, 2018
@dagwieers dagwieers added the k8s label Feb 8, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.4 This issue/PR affects Ansible v2.4 c:module_utils/ feature This issue/PR relates to a feature request. k8s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@detiber @chouseknecht @ansibot @dagwieers @bcoca