Added priority attribute for pool members (bigip_pool_member module) #23128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test |
ansibot
added
affects_2.4
ansibot
added
community_review
nitzmahone
removed
the
needs_triage
|
@ossark if you'll be a champ and rename that Also, in the future, you can file issues at this repo for the F5 modules https://github.com/F5Networks/f5-ansible We upstream those modules and changes to those modules during each Ansible release cycle. |
This was referenced Apr 3, 2017
|
@gundalow shipit This does not need to be cherry picked. |
gundalow
requested changes
Apr 6, 2017
| @@ -384,7 +402,8 @@ def main(): | |||
| description=dict(type='str'), | |||
| rate_limit=dict(type='int'), | |||
| ratio=dict(type='int'), | |||
| preserve_node=dict(type='bool', default=False) | |||
| preserve_node=dict(type='bool', default=False), | |||
| priority_group=dict(type='int') | |||
There was a problem hiding this comment.
Thus needs adding to the DOCUMENTION block code a the top of the file, just below where preserves node is documented.
This PR will be released in Ansible 2.4, so please add version_added:"2.4"
There was a problem hiding this comment.
@ossark Could you please address this then we can get this merged. Thanks for your fixes.
There was a problem hiding this comment.
@ossark Thanks for the PR, just one change then I can get this merged. Thanks :)
There was a problem hiding this comment.
Updated as requested.
ansibot
added
needs_revision
ansibot
removed
the
stale_ci
ansibot
added
stale_ci
ansibot
added
support:core
|
Give me a day or two and I should have this fixed. Thanks
… On 6 juli 2017, at 21:37, John R Barker ***@***.***> wrote:
@gundalow commented on this pull request.
In lib/ansible/modules/network/f5/bigip_pool_member.py:
> @@ -384,7 +402,8 @@ def main():
description=dict(type='str'),
rate_limit=dict(type='int'),
ratio=dict(type='int'),
- preserve_node=dict(type='bool', default=False)
+ preserve_node=dict(type='bool', default=False),
+ priority_group=dict(type='int')
@ossark Thanks for the PR, just one change then I can get this merged. Thanks :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@ossark fyi after this PR goes in, future PR's for F5 "stuff" usually start over here https://github.com/F5Networks/f5-ansible There's still time to get this in before 2.4 is released. |
ansibot
removed
the
stale_ci
ansibot
added
stale_ci
|
closing & reopening totrigger CI |
ansibot
added
stale_review
gundalow
approved these changes
Aug 1, 2017
|
Thanks. Merged into |
schunduri
pushed a commit
to schunduri/ansible
that referenced
this pull request
Aug 4, 2017
…nsible#23128) * Added priority attribute for pool members (bigip_pool_member module) * Line break missing * Change from 'priority' to 'priority_group' * Update bigip_pool_member.py * Update bigip_pool_member.py
ansibot
added
feature
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Added the ability to specify priority for pool members.
ISSUE TYPE
Feature pull request
COMPONENT NAME
bigip_pool_member
ANSIBLE VERSION