Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win_stat change return islink to islnk to match stat #23196

Merged
merged 1 commit into from
Apr 3, 2017
Merged

win_stat change return islink to islnk to match stat #23196

merged 1 commit into from
Apr 3, 2017

Conversation

jborean93
Copy link
Contributor

SUMMARY

Changed win_stat to fix return value from islink to islnk to match the stat module.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_stat

ANSIBLE VERSION
ansible 2.4.0 (devel 11138abc51) last updated 2017/04/01 12:25:17 (GMT +1000)
  config file = /mnt/c/dev/test/role/ansible.cfg
  configured module search path = [u'/mnc/c/dev/test/role/library']
  python version = 2.7.12 (default, Dec 14 2016, 21:05:07) [GCC 4.8.4]
ADDITIONAL INFORMATION

To keep the windows and unix modules as close as possible this is to change the return value from islink to islnk.

@ansibot
Copy link
Contributor

ansibot commented Apr 1, 2017

cc @nitzmahone
click here for bot help

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 bugfix_pull_request core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. windows Windows community labels Apr 1, 2017
@jborean93
Copy link
Contributor Author

@nitzmahone @jhawkesworth @dagwieers I realised the return value islink is actually islnk in the stat module. This return value was only added in 2.3 so I'm hoping we can get this through before 2.3 is officially released.

@nitzmahone
Copy link
Member

That's funny, I noticed that when I first looked at it and just blindly assumed it was carrying over the same behavior from the *nix module... Yeah, I'll merge/cherry-pick this first thing Monday for RC4 (or sooner if I get back in front of my workstation).

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Apr 1, 2017
nitzmahone
nitzmahone approved these changes Apr 3, 2017
View reviewed changes
Copy link
Member

@nitzmahone nitzmahone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job on the test cleanup, too...

@nitzmahone nitzmahone merged commit 4d1b97d into ansible:devel Apr 3, 2017
nitzmahone pushed a commit that referenced this pull request Apr 3, 2017
@jborean93 @nitzmahone
win_stat change return islink to islnk to match stat (#23196)
401f6d6 
(cherry picked from commit 4d1b97d)
@nitzmahone
Copy link
Member

cherry-picked to stable-2.3 for 2.3.0RC4

@jborean93 jborean93 deleted the win_stat-param-standard branch April 12, 2017 12:12
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nitzmahone nitzmahone nitzmahone approved these changes

Assignees

@nitzmahone nitzmahone

Labels
affects_2.4 This issue/PR affects Ansible v2.4 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jborean93 @ansibot @nitzmahone