Added support for FUNCTION and PROCEDURE privileges to mysql_user

[mklassen]

SUMMARY

Added support for FUNCTION and PROCEDURE in parsing the priv parameter of mysql_user

- mysql_user:
    user: db_user
    priv: FUNCTION dbname.function:EXECUTE/dbname.*:SELECT/PROCEDURE otherdb.procedure:EXECUTE

A privilege in priv can be prepended by FUNCTION or PROCEDURE. It should be separated from the db.table portion of the privilege by a space. This was chosen as it matches the format of the privilege as extracted in privileges_get function.

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

mysql_user

ANSIBLE VERSION

ansible 2.2.2.0

ADDITIONAL INFORMATION

Currently only TABLE privileges can be manipulated with mysql_user

Granting execute privileges on a mysql FUNCTION requires an SQL statement of the form

GRANT EXECUTE ON FUNCTION dbname.function_name TO 'user';

Unfortunately if the FUNCTION keyword is included in mysql_user modules's priv parameter it is not recognized as a valid privilege level.

Object types of FUNCTION and PROCEDURE are supported by mysql (http://dev.mysql.com/doc/refman/5.7/en/grant.html) and it would be nice if the priv parameter supported specifying 'object_type', so that task like the following could be executed

- mysql_user:
    user: db_user
    priv: FUNCTION dbname.function_name:EXECUTE
    state: present

[ansibot]

cc @Jmainguy
click here for bot help

[Jmainguy]

@mklassen code looks good, seems like a good feature to add.

Can you or anyone else reading this test this against default mysql (or mariadb) installs on centos6, centos7, and w/e latest LTS ubuntu is and ensure it works / doesnt break anything existing? And then post results of test here. (Sorry for being a terrible maintainer and not reviewing this 5 months ago, or running these tests myself, honestly if anybody is itching to be the Mysql maintainer for Ansible just let me know.)

[ansibot]

@mklassen This PR contains @ mentions in at least one commit message. Those mentions can cause cascading notifications through GitHub and need to be removed. Please squash or amend your commits to remove the mentions.

click here for bot help

[ansibot]

cc @Constantin007 @Constantin07 @DJMuggs @GGabriele @MarkusTeufelberger @NickatEpic @Qalthos @Spredzy @ThePixelDeveloper @ThomasSteinbach @abirami-n @adq @aimonb @Akasurde @alikins @amuraleedhar @bennojoy @berenddeschouwer @brandond @brian-brazil @broncofan @caphrim007 @chouseknecht @clc-runner @cloudnull @cove @dagnello @dagwieers @dav1x @defionscode @devigned @dgarros @Dhivyap @dkasberg @dkhenry @dstoflet @dusdanig @emonty @erydo @ganeshrn @garethr @goozbach @gouthampacha @groks @gundalow @gunzy83 @hacosta @haroldwongms @helldorado @hulquest @ignatenkobrain @ivanbojer @j2sol @jarv @jcpowermac @jctanner @jedelman8 @jeremyschulman @jmcgill298 @joelthompson @joshuaconner @jsdalton @jsmartin @jtschichold @juliakreger @julienstroheker @jwhitbeck @kedarX @kevensen @lmazuel @lmprice @loia @lujeni @lwade @machacekondra @matburt @mattupstate @maxamillion @mcltn @mcv21 @mgruener @mgwilliams @mikewiebe @mjschultz @mkrizek @mwperina @nand0p @nerzhul @nitzmahone @obsoleted @ogenstad @ozboms @pdellaert @privateip @Qalthos @rahushen @rcarrillocruz @rickmendes @rnh556 @robinro @ryansb @s-hertel @saito-hideki @samdoran @schunduri @scicoin-project @seiffert @sgargan @shepdelacreme @shrews @skg-net @smbambling @softzilla @tedder @tgerla @thingee @tintoy @trishnaguha @tstringer @verm666 @willthames @wilvk @wimnat @xscript @yaegashi @yuwzho @zfil @zikalino
click here for bot help

[ansibot]

@mklassen this PR contains more than one new module.

Please submit only one new module per pullrequest. For further explanation, please read grouped module documentation

click here for bot help

[mklassen]

Addresses issue #29511

[caphrim007]

lgtm. tested on mariadb 10.3